Linaro Image Tools

Code review comment for lp:~dooferlad/linaro-image-tools/fix-hwpack-no-internet

  1. fix-hwpack-no-internet
  2. Merge into trunk
Revision history for this message
Milo Casagrande (milo) wrote :

Hello James,

it looks OK to me. I double tested it with latest hwpack/images and also with the oldest I could find. I would need to thoroughly check it also on a 10.04 install. I cannot go back more than 11.07 on releases.l.o.

Just one thing, but not that important:

+ $sudo apt-get $FORCE_OPTIONS -o "$APT_GET_OPTIONS" update -q --no-download

Should we add also the "--no-missing" here to really force no download at all?
In case, add when merging.

review: Approve

« Back to merge proposal