Code review comment for lp:~dooferlad/linaro-image-tools/copy-files-new-syntax

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

342 - for expected_file, contents in expected_files:
343 - self.assertThat(
344 - tf, TarfileHasFile(expected_file, content=contents))
345 + stored_package_names = [p.name for p in builder.packages]
346 + for package_name in package_names:
347 + self.assertIn(package_name, stored_package_names)

I'm again not sure about this change - old version did check that file comes from the expected package and not some else, I don't the new does.

review: Needs Fixing

« Back to merge proposal