Code review comment for lp:~dooferlad/linaro-image-tools/copy-files-new-syntax

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

> [package for package in copy_files] - that looks a bit strange. Was "copy_files[:]" meant instead (make a copy of list)?

Ah, I see, that's unobvious way to do copy_files.keys(). Btw, I missed moment when they allowed iteration on dict directly, and that started to mean iteration over its keys. I still think that doing it explicitly ("for i in a.iterkeys()") is more clear.

« Back to merge proposal