Merge lp:~dooferlad/linaro-android-frontend/proxy_lava-job-info_updates into lp:linaro-android-frontend

Proposed by James Tunnicliffe
Status: Merged
Merged at revision: 243
Proposed branch: lp:~dooferlad/linaro-android-frontend/proxy_lava-job-info_updates
Merge into: lp:linaro-android-frontend
Diff against target: 36 lines (+10/-4)
2 files modified
android_build/frontend/api.py (+6/-2)
static/buildDetails.js (+4/-2)
To merge this branch: bzr merge lp:~dooferlad/linaro-android-frontend/proxy_lava-job-info_updates
Reviewer Review Type Date Requested Status
Paul Sokolovsky Approve
Review via email: mp+88095@code.launchpad.net

Description of the change

Fixes problems seen on deployment of last branch.

To post a comment you must log in.
Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Looks good.

review: Approve
Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Merged, but not deployed, let's do it tomorrow.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'android_build/frontend/api.py'
--- android_build/frontend/api.py 2012-01-09 18:27:49 +0000
+++ android_build/frontend/api.py 2012-01-10 18:13:25 +0000
@@ -276,10 +276,14 @@
276 try:276 try:
277 response = urllib2.urlopen(url)277 response = urllib2.urlopen(url)
278 except urllib2.HTTPError, e:278 except urllib2.HTTPError, e:
279 message = "Server error: {}".format(e.code)279 message = "Server error: %d" % e.code
280 return HttpResponse(message)280 return HttpResponse(message)
281 except urllib2.URLError, e:281 except urllib2.URLError, e:
282 message = "We failed to reach a server. Reason{}".format(e.reason)282 message = "We failed to reach a server."
283
284 if isinstance(e.reason, str):
285 message += " Reason %s" % e.reason
286
283 return HttpResponse(message)287 return HttpResponse(message)
284 else:288 else:
285 return HttpResponse(response.read())289 return HttpResponse(response.read())
286290
=== modified file 'static/buildDetails.js'
--- static/buildDetails.js 2012-01-10 13:34:52 +0000
+++ static/buildDetails.js 2012-01-10 18:13:25 +0000
@@ -102,8 +102,10 @@
102102
103 if (typeof receivedLavaJobInfo.got_info != "undefined")103 if (typeof receivedLavaJobInfo.got_info != "undefined")
104 {104 {
105// alert("Two resutls files found. Please report this error by submitting a bug report against" +105 // Don't pass through a second job info. Assumption is that they are the same
106// " https://code.launchpad.net/~linaro-infrastructure/linaro-android-frontend/trunk")106 // so it doesn't matter if we find several and they are just duplicates. This
107 // happened around 12-2011 when we started to migrate build outputs to
108 // snapshots.linaro.org.
107 return;109 return;
108 }110 }
109111

Subscribers

People subscribed via source and target branches