Code review comment for lp:~donkirkby/openobject-server/config-defaults

Revision history for this message
Don Kirkby (donkirkby) wrote :

This is the work that I proposed in the bug discussion. I have tested it with all the options described in the code, and compared the in-memory values to those generated by

the old code. I also compared the configuration files saved by my new code and the old code.

In addition to adding support for all options in the configuration file and the command line, the following behaviours have changed:

- The reference to the soap option had been commented out from openerp-server.py and it wasn't allowed on the command line, so I removed it from the defaults.
- translate_modules now reads and writes to the configuration file in the same format that it uses on the command line. If it sees the old format, it continues to ignore it

during load, just like the old code did.
- netport and port used to be strings when loaded from a configuration file, and integers when loaded from the command line. They are now always integers.
- demo is no longer saved to the configuration file. (It was ignored during load, so this should be irrelevant.)

I did not get around to adding new names for the command line options that don't match their names in the configuration file.

I tried to break up the changes into smaller revisions to make the review easier. If there's something I can do to make my next proposal easier to review, please let me know.

« Back to merge proposal