Odoo Addons (MOVED TO GITHUB)

Code review comment for lp:~donkirkby/openobject-addons/mrp-jit-restart

  1. mrp-jit-restart
  2. Merge into 5.0
Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

Further analysis: this was broken by revision 1634, it used to work before:
  http://bazaar.launchpad.net/~openerp/openobject-addons/5.0/revision/1634

The workaround I propose instead of this 'button_restart' hack, and short of reverting rev 1634, is to allow mrp.procurement.action_confirm() to also confirm draft stock.moves, not just 'waiting' ones.
This change also seems sensible and correct to me.

The patch is trivial, but as I said on bug 522977, I still need a test case before landing it on stable. Hopefully I will be able to do that tomorrow before 5.0.7.

If you want to help test it, I will attach the patch to the bug now.

review: Disapprove (incorrect functional patch)
Reply

« Back to merge proposal