Merge lp:~donadigo/wingpanel-indicator-notifications/ignore-canonical-private-key into lp:~wingpanel-devs/wingpanel-indicator-notifications/wingpanel-indicator-notifications

[Adam Bieńkowski]

Ignore notifications with "x-canonical-private-synchronous" key: do not show sound & brightness changes.
Use on_switch_stack instead of only changing the icon.

This branch prevents notifications with a key of "x-canonical-private-synchronous" to show in the indicator (ie: sound, brightness changes). This is also allowing us to remove the hardcoded senders since they also use this key.

=== modified file 'src/Indicator.vala'
--- src/Indicator.vala	2016-07-20 20:17:06 +0000
+++ src/Indicator.vala	2016-08-02 13:14:01 +0000
@@ -16,7 +16,7 @@
  */
 
 public class Indicator : Wingpanel.Indicator {
-    private const string[] EXCEPTIONS = { "wingpanel-indicator-sound", "indicator-sound", "NetworkManager", "gnome-settings-daemon", "gnome-power-panel" };
+    private const string[] EXCEPTIONS = { "NetworkManager", "gnome-settings-daemon", "gnome-power-panel" };
     private const string CHILD_SCHEMA_ID = "org.pantheon.desktop.gala.notifications.application";
     private const string CHILD_PATH = "/org/pantheon/desktop/gala/notifications/applications/%s/";
     private const string REMEMBER_KEY = "remember";
 
=== modified file 'src/Services/Notification.vala'
--- src/Services/Notification.vala	2016-07-20 20:11:51 +0000
+++ src/Services/Notification.vala	2016-08-02 13:14:01 +0000
@@ -52,6 +52,7 @@
     }
 
     private const string DEFAULT_ACTION = "default";
+    private const string X_CANONICAL_PRIVATE_KEY = "x-canonical-private-synchronous";
     private const string DESKTOP_ENTRY_KEY = "desktop-entry";
     private const string FALLBACK_DESKTOP_ID = "gala-other" + DESKTOP_ID_EXT;
     private bool pid_accuired;
@@ -125,7 +126,7 @@
     }
 
     public bool get_is_valid () {
-        return app_info != null;
+        return app_info != null && hints.lookup_value (X_CANONICAL_PRIVATE_KEY, null) == null;
     }
 
     public bool run_default_action () {