Merge lp:~donadigo/wingpanel-indicator-notifications/display-all into lp:~wingpanel-devs/wingpanel-indicator-notifications/wingpanel-indicator-notifications

Proposed by Adam Bieńkowski
Status: Merged
Approved by: Felipe Escoto
Approved revision: 97
Merged at revision: 96
Proposed branch: lp:~donadigo/wingpanel-indicator-notifications/display-all
Merge into: lp:~wingpanel-devs/wingpanel-indicator-notifications/wingpanel-indicator-notifications
Diff against target: 44 lines (+5/-16)
2 files modified
src/Services/NotificationsMonitor.vala (+4/-15)
src/Widgets/NotificationsList.vala (+1/-1)
To merge this branch: bzr merge lp:~donadigo/wingpanel-indicator-notifications/display-all
Reviewer Review Type Date Requested Status
WingPanel Devs Pending
Review via email: mp+297905@code.launchpad.net

Commit message

* Fix bug #1594062: "Display all notifications instead of catching closed ones".
* Fixed a warning with removing widget from container.

Description of the change

Fixes bug #1594062: "Display all notifications instead of catching closed ones".

Remove catching closed notifications logic, now they'll be available immediately after the server call. Also fixed a warning with removing widget from container.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/Services/NotificationsMonitor.vala'
--- src/Services/NotificationsMonitor.vala 2016-05-27 15:10:53 +0000
+++ src/Services/NotificationsMonitor.vala 2016-06-20 12:44:19 +0000
@@ -90,24 +90,13 @@
90 current_id = id_counter;90 current_id = id_counter;
91 }91 }
9292
93 if (NotifySettings.get_instance ().do_not_disturb) {93 Idle.add (() => {
94 this.received (message, current_id);94 this.received (message, current_id);
95 } else {95 message = null;
96 notifications_iface.notification_closed.connect ((id, reason) => {96 return false;
97 if (id == 1) {97 });
98 id_counter = id;
99 current_id = id_counter;
100 }
101
102 if (reason != REASON_DISMISSED && current_id == id) {
103 this.received (message, id);
104 message = null;
105 }
106 });
107 }
10898
109 return null;99 return null;
110
111 }100 }
112 }101 }
113102
114103
=== modified file 'src/Widgets/NotificationsList.vala'
--- src/Widgets/NotificationsList.vala 2016-05-27 15:10:53 +0000
+++ src/Widgets/NotificationsList.vala 2016-06-20 12:44:19 +0000
@@ -167,7 +167,7 @@
167 app_entries.remove (app_entry);167 app_entries.remove (app_entry);
168168
169 app_entry.get_notifications ().@foreach ((notification_entry) => {169 app_entry.get_notifications ().@foreach ((notification_entry) => {
170 remove (notification_entry);170 notification_entry.destroy ();
171 items.remove (notification_entry);171 items.remove (notification_entry);
172 });172 });
173173

Subscribers

People subscribed via source and target branches

to all changes: