Merge lp:~donadigo/wingpanel-indicator-notifications/display-all into lp:~wingpanel-devs/wingpanel-indicator-notifications/wingpanel-indicator-notifications

Proposed by Adam Bieńkowski
Status: Merged
Approved by: Felipe Escoto
Approved revision: 97
Merged at revision: 96
Proposed branch: lp:~donadigo/wingpanel-indicator-notifications/display-all
Merge into: lp:~wingpanel-devs/wingpanel-indicator-notifications/wingpanel-indicator-notifications
Diff against target: 44 lines (+5/-16)
2 files modified
src/Services/NotificationsMonitor.vala (+4/-15)
src/Widgets/NotificationsList.vala (+1/-1)
To merge this branch: bzr merge lp:~donadigo/wingpanel-indicator-notifications/display-all
Reviewer Review Type Date Requested Status
WingPanel Devs Pending
Review via email: mp+297905@code.launchpad.net

Commit message

* Fix bug #1594062: "Display all notifications instead of catching closed ones".
* Fixed a warning with removing widget from container.

Description of the change

Fixes bug #1594062: "Display all notifications instead of catching closed ones".

Remove catching closed notifications logic, now they'll be available immediately after the server call. Also fixed a warning with removing widget from container.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Services/NotificationsMonitor.vala'
2--- src/Services/NotificationsMonitor.vala 2016-05-27 15:10:53 +0000
3+++ src/Services/NotificationsMonitor.vala 2016-06-20 12:44:19 +0000
4@@ -90,24 +90,13 @@
5 current_id = id_counter;
6 }
7
8- if (NotifySettings.get_instance ().do_not_disturb) {
9+ Idle.add (() => {
10 this.received (message, current_id);
11- } else {
12- notifications_iface.notification_closed.connect ((id, reason) => {
13- if (id == 1) {
14- id_counter = id;
15- current_id = id_counter;
16- }
17-
18- if (reason != REASON_DISMISSED && current_id == id) {
19- this.received (message, id);
20- message = null;
21- }
22- });
23- }
24+ message = null;
25+ return false;
26+ });
27
28 return null;
29-
30 }
31 }
32
33
34=== modified file 'src/Widgets/NotificationsList.vala'
35--- src/Widgets/NotificationsList.vala 2016-05-27 15:10:53 +0000
36+++ src/Widgets/NotificationsList.vala 2016-06-20 12:44:19 +0000
37@@ -167,7 +167,7 @@
38 app_entries.remove (app_entry);
39
40 app_entry.get_notifications ().@foreach ((notification_entry) => {
41- remove (notification_entry);
42+ notification_entry.destroy ();
43 items.remove (notification_entry);
44 });
45

Subscribers

People subscribed via source and target branches

to all changes: