Code review comment for lp:~donadigo/switchboard/plug-use-search-entry

Revision history for this message
Corentin Noël (tintou) wrote :

This does already the job :

public abstract async Gee.TreeMap<string, string> search (string search);

indeed, our client doesn't make use of this right now, but here is how it should work:
 * When the search entry is changed, it calls this search function with the search string
 * The TreeMap contains some "Keyboard → Behavior → Duration", "keyboard<sep>behavior" if there are result, otherwise it is empty.
So it is up to the client to show the search results, but it's currently not implemented in the client.

review: Needs Fixing

« Back to merge proposal