Merge lp:~donadigo/switchboard/correct-app-id into lp:~elementary-pantheon/switchboard/switchboard

Proposed by Adam Bieńkowski
Status: Merged
Approved by: Danielle Foré
Approved revision: 696
Merged at revision: 696
Proposed branch: lp:~donadigo/switchboard/correct-app-id
Merge into: lp:~elementary-pantheon/switchboard/switchboard
Diff against target: 30 lines (+3/-3)
2 files modified
CMakeLists.txt (+2/-2)
src/Switchboard.vala (+1/-1)
To merge this branch: bzr merge lp:~donadigo/switchboard/correct-app-id
Reviewer Review Type Date Requested Status
elementary Pantheon team Pending
Review via email: mp+310104@code.launchpad.net

Commit message

* Changed .desktop name to it's app id

Description of the change

Fix bug #1593926: ".desktop file name needs to be its AppID".

Corrects the app ID for the desktop file and in the code.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2016-11-01 01:16:45 +0000
+++ CMakeLists.txt 2016-11-04 22:38:31 +0000
@@ -68,10 +68,10 @@
68#68#
6969
70include (Translations)70include (Translations)
71configure_file_translation(${CMAKE_SOURCE_DIR}/data/${CMAKE_PROJECT_NAME}.desktop.in ${CMAKE_BINARY_DIR}/data/${CMAKE_PROJECT_NAME}.desktop ${CMAKE_SOURCE_DIR}/po/)71configure_file_translation(${CMAKE_SOURCE_DIR}/data/org.pantheon.switchboard.desktop.in ${CMAKE_BINARY_DIR}/data/org.pantheon.switchboard.desktop ${CMAKE_SOURCE_DIR}/po/)
72configure_file_translation(${CMAKE_SOURCE_DIR}/data/${CMAKE_PROJECT_NAME}.appdata.xml.in ${CMAKE_BINARY_DIR}/data/${CMAKE_PROJECT_NAME}.appdata.xml ${CMAKE_SOURCE_DIR}/po/)72configure_file_translation(${CMAKE_SOURCE_DIR}/data/${CMAKE_PROJECT_NAME}.appdata.xml.in ${CMAKE_BINARY_DIR}/data/${CMAKE_PROJECT_NAME}.appdata.xml ${CMAKE_SOURCE_DIR}/po/)
7373
74install(FILES ${CMAKE_BINARY_DIR}/data/${CMAKE_PROJECT_NAME}.desktop DESTINATION ${DATADIR}/applications)74install(FILES ${CMAKE_BINARY_DIR}/data/org.pantheon.switchboard.desktop DESTINATION ${DATADIR}/applications)
75install(FILES ${CMAKE_BINARY_DIR}/data/${CMAKE_PROJECT_NAME}.appdata.xml DESTINATION ${DATADIR}/appdata)75install(FILES ${CMAKE_BINARY_DIR}/data/${CMAKE_PROJECT_NAME}.appdata.xml DESTINATION ${DATADIR}/appdata)
7676
77add_subdirectory(po)77add_subdirectory(po)
7878
=== renamed file 'data/switchboard.desktop.in' => 'data/org.pantheon.switchboard.desktop.in'
=== modified file 'src/Switchboard.vala'
--- src/Switchboard.vala 2016-11-03 21:28:25 +0000
+++ src/Switchboard.vala 2016-11-04 22:38:31 +0000
@@ -66,7 +66,7 @@
66 };66 };
6767
68 construct {68 construct {
69 application_id = "org.elementary.switchboard";69 application_id = "org.pantheon.switchboard";
70 program_name = _("System Settings");70 program_name = _("System Settings");
71 app_years = "2011-2016";71 app_years = "2011-2016";
72 exec_name = "switchboard";72 exec_name = "switchboard";

Subscribers

People subscribed via source and target branches

to all changes: