Merge lp:~donadigo/switchboard-plug-networking/wifi-list-placeholders into lp:~elementary-pantheon/switchboard-plug-networking/trunk
Proposed by
Adam Bieńkowski
Status: | Rejected |
---|---|
Rejected by: | Adam Bieńkowski |
Proposed branch: | lp:~donadigo/switchboard-plug-networking/wifi-list-placeholders |
Merge into: | lp:~elementary-pantheon/switchboard-plug-networking/trunk |
Diff against target: |
110 lines (+62/-3) 1 file modified
src/common/Widgets/AbstractWifiInterface.vala (+62/-3) |
To merge this branch: | bzr merge lp:~donadigo/switchboard-plug-networking/wifi-list-placeholders |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Adam Bieńkowski (community) | Abstain | ||
elementary Apps team | Pending | ||
Review via email: mp+266719@code.launchpad.net |
Commit message
Added new placeholders that will adapt to the situation of wifi list:
* When there are no available access points
* When wireless is disabled
* When scanning for access points
Description of the change
Added new placeholders that will adapt to the situation of wifi list:
* When there are no available access points
* When wireless is disabled
* When scanning for access points
To post a comment you must log in.
Hm I think if we're following the regular alert layout, it seems like what we want is more like:
Wireless Is Disabled
Enable wireless to discover nearby wireless access points
No Access Points Available
There are no wireless access points within range
Also, see an inline comment about ellipsis