Merge lp:~donadigo/gala/simple-dialog-animation into lp:gala

Proposed by Adam Bieńkowski
Status: Merged
Merged at revision: 548
Proposed branch: lp:~donadigo/gala/simple-dialog-animation
Merge into: lp:gala
Diff against target: 34 lines (+6/-6)
1 file modified
src/WindowManager.vala (+6/-6)
To merge this branch: bzr merge lp:~donadigo/gala/simple-dialog-animation
Reviewer Review Type Date Requested Status
Danielle Foré ux Approve
Review via email: mp+311284@code.launchpad.net

Commit message

* Change dialog animations to be simpler

Description of the change

This branch changes the show / hide dialog animations. These are now much faster, instead of sliding from top they are now scaling from the center increasing their opacity. It looks simpler and makes the window contents not strech in any way.

To post a comment you must log in.
548. By Adam Bieńkowski

Make dialog animations simpler

Revision history for this message
Danielle Foré (danrabbit) wrote :

So the original dialog animation is the way it is because originally we had the modal sheets that were attached to the window, but since that idea was thrown out I agree that this kind of animation makes more sense :)

review: Approve (ux)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/WindowManager.vala'
--- src/WindowManager.vala 2016-08-04 07:37:29 +0000
+++ src/WindowManager.vala 2016-11-18 16:57:20 +0000
@@ -1082,13 +1082,13 @@
10821082
1083 mapping.add (actor);1083 mapping.add (actor);
10841084
1085 actor.set_pivot_point (0.5f, 0.0f);1085 actor.set_pivot_point (0.5f, 0.5f);
1086 actor.set_scale (1.0f, 0.0f);1086 actor.set_scale (0.9f, 0.9f);
1087 actor.opacity = 0;1087 actor.opacity = 0;
10881088
1089 actor.save_easing_state ();1089 actor.save_easing_state ();
1090 actor.set_easing_mode (Clutter.AnimationMode.EASE_OUT_QUAD);1090 actor.set_easing_mode (Clutter.AnimationMode.EASE_OUT_QUAD);
1091 actor.set_easing_duration (250);1091 actor.set_easing_duration (150);
1092 actor.set_scale (1.0f, 1.0f);1092 actor.set_scale (1.0f, 1.0f);
1093 actor.opacity = 255U;1093 actor.opacity = 255U;
1094 actor.restore_easing_state ();1094 actor.restore_easing_state ();
@@ -1165,11 +1165,11 @@
1165 case WindowType.DIALOG:1165 case WindowType.DIALOG:
1166 destroying.add (actor);1166 destroying.add (actor);
11671167
1168 actor.set_pivot_point (0.5f, 0.0f);1168 actor.set_pivot_point (0.5f, 0.5f);
1169 actor.save_easing_state ();1169 actor.save_easing_state ();
1170 actor.set_easing_mode (Clutter.AnimationMode.EASE_OUT_QUAD);1170 actor.set_easing_mode (Clutter.AnimationMode.EASE_OUT_QUAD);
1171 actor.set_easing_duration (200);1171 actor.set_easing_duration (100);
1172 actor.set_scale (1.0f, 0.0f);1172 actor.set_scale (0.9f, 0.9f);
1173 actor.opacity = 0U;1173 actor.opacity = 0U;
1174 actor.restore_easing_state ();1174 actor.restore_easing_state ();
11751175

Subscribers

People subscribed via source and target branches