Gala

Merge lp:~donadigo/gala/simple-dialog-animation into lp:gala

  1. simple-dialog-animation
  2. Merge into trunk
Proposed by Adam Bieńkowski
Status: Merged
Merged at revision: 548
Proposed branch: lp:~donadigo/gala/simple-dialog-animation
Merge into: lp:gala
Diff against target: 34 lines (+6/-6)
1 file modified
src/WindowManager.vala (+6/-6)
To merge this branch: bzr merge lp:~donadigo/gala/simple-dialog-animation
Reviewer Review Type Date Requested Status
Danielle Foré ux Approve
Review via email: mp+311284@code.launchpad.net

Commit message

* Change dialog animations to be simpler

Description of the change

This branch changes the show / hide dialog animations. These are now much faster, instead of sliding from top they are now scaling from the center increasing their opacity. It looks simpler and makes the window contents not strech in any way.

To post a comment you must log in.
lp:~donadigo/gala/simple-dialog-animation updated
548. By Adam Bieńkowski

Make dialog animations simpler

Revision history for this message
Danielle Foré (danrabbit) wrote :

So the original dialog animation is the way it is because originally we had the modal sheets that were attached to the window, but since that idea was thrown out I agree that this kind of animation makes more sense :)

review: Approve (ux)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/WindowManager.vala'
2--- src/WindowManager.vala 2016-08-04 07:37:29 +0000
3+++ src/WindowManager.vala 2016-11-18 16:57:20 +0000
4@@ -1082,13 +1082,13 @@
5
6 mapping.add (actor);
7
8- actor.set_pivot_point (0.5f, 0.0f);
9- actor.set_scale (1.0f, 0.0f);
10+ actor.set_pivot_point (0.5f, 0.5f);
11+ actor.set_scale (0.9f, 0.9f);
12 actor.opacity = 0;
13
14 actor.save_easing_state ();
15 actor.set_easing_mode (Clutter.AnimationMode.EASE_OUT_QUAD);
16- actor.set_easing_duration (250);
17+ actor.set_easing_duration (150);
18 actor.set_scale (1.0f, 1.0f);
19 actor.opacity = 255U;
20 actor.restore_easing_state ();
21@@ -1165,11 +1165,11 @@
22 case WindowType.DIALOG:
23 destroying.add (actor);
24
25- actor.set_pivot_point (0.5f, 0.0f);
26+ actor.set_pivot_point (0.5f, 0.5f);
27 actor.save_easing_state ();
28 actor.set_easing_mode (Clutter.AnimationMode.EASE_OUT_QUAD);
29- actor.set_easing_duration (200);
30- actor.set_scale (1.0f, 0.0f);
31+ actor.set_easing_duration (100);
32+ actor.set_scale (0.9f, 0.9f);
33 actor.opacity = 0U;
34 actor.restore_easing_state ();
35

Subscribers

People subscribed via source and target branches