Merge lp:~donadigo/appcenter/install-notify-canceled into lp:~elementary-apps/appcenter/appcenter
Proposed by
Adam Bieńkowski
Status: | Rejected |
---|---|
Rejected by: | Adam Bieńkowski |
Proposed branch: | lp:~donadigo/appcenter/install-notify-canceled |
Merge into: | lp:~elementary-apps/appcenter/appcenter |
Diff against target: |
71 lines (+17/-12) (has conflicts) 2 files modified
src/Core/Client.vala (+8/-0) src/Core/Package.vala (+9/-12) Text conflict in src/Core/Client.vala |
To merge this branch: | bzr merge lp:~donadigo/appcenter/install-notify-canceled |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Danielle Foré | Approve | ||
Cody Garver (community) | Abstain | ||
Review via email: mp+298052@code.launchpad.net |
Commit message
Check if the action was canceled if yes, do not send the notification
Description of the change
Fixes bug #1592291: "Application installed Notification even if you canceled".
Check if the action was canceled if yes, do not send the notification.
To post a comment you must log in.
Unmerged revisions
- 211. By Adam Bieńkowski
-
Actually fix the issue
- 210. By Adam Bieńkowski
-
Do not send notification when not installed
I'm unable to review this because I can't get any installation to cancel, they just keep installing...