Code review comment for lp:~doflah/ubuntu-calendar-app/testing

Revision history for this message
Olivier Tilloy (osomon) wrote :

Overall this looks like a great addition to the already existing autopilot tests, to ensure no regressions in the JS helpers. Thanks for this!

A few remarks:

 - For consistency with other apps, instead of "unit-tests/", I would place those tests under "tests/unittests/" (when you do that you’ll have to add another "../" to the import statement for dateExt.js.

 - It would be great to have the build system automatically run those tests when building a package. To achieve this, you’ll need to apply the following changes:

=== modified file 'debian/control'
--- debian/control 2013-08-20 08:24:45 +0000
+++ debian/control 2013-09-23 11:23:04 +0000
@@ -1,7 +1,8 @@
 Source: calendar-app
 Priority: extra
 Maintainer: Ubuntu App Cats <email address hidden>
-Build-Depends: debhelper (>= 9),
+Build-Depends: debhelper (>= 9),
+ qtdeclarative5-dev-tools,
 Standards-Version: 3.9.4
 Section: misc
 Homepage: https://launchpad.net/ubuntu-calendar-app

=== modified file 'debian/rules'
--- debian/rules 2013-06-17 11:10:21 +0000
+++ debian/rules 2013-09-23 11:20:25 +0000
@@ -7,6 +7,9 @@
 %:
  dh $@

+override_dh_auto_test:
+ QT_QPA_PLATFORM=minimal qmltestrunner -input tests/unittests/
+
 override_dh_install:
  dh_install --fail-missing
  appname=calendar-app; \

« Back to merge proposal