Code review comment for lp:~doctormo/inkscape/barcode-refactor
Revision history for this message
| su_v (suv-lp) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
Some error messages for invalid input seem rather cryptic now: e.g.
Error encoding '1234567890123' as upce barcode: Wrong size, must be 6, 1, 1, 7, 1, 2 digits
No barcode was generated
This gives not many clues how a correct size must look (at least to me). The error message of the previous code (in 0.48.0) seems clearer to me:
Can not encode '1234567890123' into UPC-E Barcode, Size must be 6 numbers only, and 1 check digit (optional)
Or a convertable 11 digit UPC-A number with 1 check digit (also optional).
No barcode was generated
But maybe this type of discussion should happen after the merge?