Code review comment for lp:~docky-core/plank/themes

> Why do you have get_default_theme_folder and get_theme_folder? It appears the
> first is just a special case of the latter (for the default theme) and not
> needed. Also the default one is for some reason preferring global theme over
> user theme (which should NEVER be the case).

This behavior is intended. I want to preserve the ability of plank to generate the files of its internal default theme which is only possible in the user-folder. So if the choice/fallback is "Default" use the installed/packaged (distro-)theme, and if that isn't available use the writeable user-folder to generate it or use the existing one.

The error is there since it is an assert and should never happen.