Code review comment for lp:~docky-core/plank/launcher-uri

Revision history for this message
Robert Dyer (psybers) wrote :

diff lines 94-106 -> each individual to_uri call needs its own try/catch block

This is because the first one might be invalid, but the rest may be valid. With 1 try/catch, if the first throws then none will be added to the dock. Individual try/catches will only skip ones that threw individually.

review: Needs Fixing

« Back to merge proposal