Code review comment for lp:~dobey/unity-scope-click/translated

Revision history for this message
David Planella (dpm) wrote :

That answered my questions, LGTM!

For translations to be exposed in the upstream project and shared with the source package, I recommend committing the .pot file to the source tree, as we do with other Ubuntu upstreams. Launchpad does not support .pot autogeneration for cmake projects, so to enable automatic translation imports and exports, the .pot file has to be present in the source tree for LP.

For translations in the source package, dh-translations should already take care of everything.

review: Approve

« Back to merge proposal