Code review comment for lp:~dobey/unity-scope-click/submit-reviews-backend

Revision history for this message
Alejandro J. Cura (alecu) wrote :

Branch looks good, but please add some test that checks that the json is being built right, and that both unicode and json special characters are escaped properly.

For this, it might make sense to refactor into a new function the bits that create the json, including the root.toStyledString(), then add a few tests for this function, plus one test that checks that Reviews::submit_review calls it right.

review: Needs Fixing

« Back to merge proposal