Merge lp:~dobey/unity-scope-click/sign-all into lp:unity-scope-click

[dobey]

Sign the requests to CPI by default.
Add tests to ensure signing is requested.

[Alejandro J. Cura (alecu)]

Looks good!

review: Approve

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:359
http://jenkins.qa.ubuntu.com/job/unity-scope-click-ci/667/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-click-wily-amd64-ci/73
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-click-wily-armhf-ci/69
        deb: http://jenkins.qa.ubuntu.com/job/unity-scope-click-wily-armhf-ci/69/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-click-ci/667/rebuild

review: Approve (continuous-integration)

=== modified file 'libclickscope/click/index.cpp'
--- libclickscope/click/index.cpp	2015-06-12 21:43:36 +0000
+++ libclickscope/click/index.cpp	2015-08-11 20:19:38 +0000
@@ -152,7 +152,7 @@
     const std::string built_query(build_index_query(query, ""));
     params.add(click::QUERY_ARGNAME, built_query.c_str());
     QSharedPointer<click::web::Response> response(client->call(
-        get_base_url() + click::SEARCH_PATH, "GET", false, build_headers(), "", params));
+        get_base_url() + click::SEARCH_PATH, "GET", true, build_headers(), "", params));
 
     QObject::connect(response.data(), &click::web::Response::finished, [=](QString reply) {
             std::pair<Packages, Packages> package_lists;
@@ -179,7 +179,7 @@
 {
     click::web::CallParams params;
     QSharedPointer<click::web::Response> response(client->call(
-        department_href, "GET", false, build_headers(), "", params));
+        department_href, "GET", true, build_headers(), "", params));
 
     QObject::connect(response.data(), &click::web::Response::finished, [=](QString reply) {
             qDebug() << "departments request finished";
 
=== modified file 'libclickscope/tests/test_index.cpp'
--- libclickscope/tests/test_index.cpp	2014-08-11 18:30:00 +0000
+++ libclickscope/tests/test_index.cpp	2015-08-11 20:19:38 +0000
@@ -104,6 +104,42 @@
     indexPtr->search("", [](click::Packages, click::Packages) {});
 }
 
+TEST_F(IndexTest, testSearchSignsCall)
+{
+    LifetimeHelper<click::network::Reply, MockNetworkReply> reply;
+    auto response = responseForReply(reply.asSharedPtr());
+
+    EXPECT_CALL(*clientPtr, callImpl(_, _, true, _, _, _))
+            .Times(1)
+            .WillOnce(Return(response));
+
+    indexPtr->search("", [](click::Packages, click::Packages) {});
+}
+
+TEST_F(IndexTest, testBootstrapSignsCall)
+{
+    LifetimeHelper<click::network::Reply, MockNetworkReply> reply;
+    auto response = responseForReply(reply.asSharedPtr());
+
+    EXPECT_CALL(*clientPtr, callImpl(_, _, true, _, _, _))
+            .Times(1)
+            .WillOnce(Return(response));
+
+    indexPtr->bootstrap([](const click::DepartmentList&, const click::HighlightList&, click::Index::Error, int) {});
+}
+
+TEST_F(IndexTest, testDepartmentsSignsCall)
+{
+    LifetimeHelper<click::network::Reply, MockNetworkReply> reply;
+    auto response = responseForReply(reply.asSharedPtr());
+
+    EXPECT_CALL(*clientPtr, callImpl(_, _, true, _, _, _))
+            .Times(1)
+            .WillOnce(Return(response));
+
+    indexPtr->departments("departments", [](const click::DepartmentList&, const click::HighlightList&, click::Index::Error, int) {});
+}
+
 TEST_F(IndexTest, testSearchSendsBuiltQueryAsParam)
 {
     const std::string FAKE_BUILT_QUERY = "FAKE_QUERY,frameworks:fake-14.04,architecture:fake-arch";