Code review comment for lp:~dobey/unity-scope-click/payments-button

Revision history for this message
dobey (dobey) wrote :

> The branch looks ok, but I think it would be safer to keep this feature behind
> an environ variable, so it does not break when the index starts having prices.
> Please add such a check in the "if (details.package.price > double(0.00)) {".

Can you approve without this, as we discussed in the standup? Given the timeframe of getting this feature landed in the archive, I don't see a good reason to do this. We'd have to remove such a check very soon, and if anything does break, it's better for us to know about it earlier, rather than only finding out if someone discovers how to enable the magic environment variable on their phone.

« Back to merge proposal