Merge lp:~dobey/unity-scope-click/merge-trunk into lp:unity-scope-click/devel

Proposed by dobey
Status: Merged
Approved by: dobey
Approved revision: no longer in the source branch.
Merged at revision: 264
Proposed branch: lp:~dobey/unity-scope-click/merge-trunk
Merge into: lp:unity-scope-click/devel
Diff against target: 106 lines (+42/-7)
3 files modified
debian/changelog (+35/-0)
scope/tests/test_index.cpp (+1/-1)
scope/tests/test_query.cpp (+6/-6)
To merge this branch: bzr merge lp:~dobey/unity-scope-click/merge-trunk
Reviewer Review Type Date Requested Status
dobey (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+220316@code.launchpad.net

Commit message

Merge release revisions from trunk back to devel.
Don't use empty strings for the icon and app URIs in the tests.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
dobey (dobey) :
review: Approve
264. By dobey

Merge release revisions from trunk back to devel.
Don't use empty strings for the icon and app URIs in the tests.

Approved by Rodney Dawes, PS Jenkins bot.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2014-05-06 17:24:10 +0000
+++ debian/changelog 2014-05-20 18:31:10 +0000
@@ -1,3 +1,38 @@
1unity-scope-click (0.1+14.10.20140520-0ubuntu1) utopic; urgency=low
2
3 [ Rodney Dawes ]
4 * Don't use empty strings for the icon and app URIs in the tests. (LP:
5 #1321312)
6
7 -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Tue, 20 May 2014 14:57:40 +0000
8
9unity-scope-click (0.1+14.10.20140516-0ubuntu1) utopic; urgency=low
10
11 [ Rodney Dawes ]
12 * Improve the text in the uninstall confirmation dialog per latest
13 design. (LP: #1234211). Reorder the header and screenshots to more
14 closely match the new design. Translations updates. Update autopilot
15 tests for some changes in apps and unity8. Log the response body on
16 network errors. Initial work for splitting scope per new designs.
17 Support running unit tests under valgrind. (LP: #1234211)
18
19 -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Fri, 16 May 2014 15:34:59 +0000
20
21unity-scope-click (0.1+14.10.20140508.1-0ubuntu1) utopic; urgency=low
22
23 [ Ubuntu daily release ]
24 * New rebuild forced
25
26 [ Rodney Dawes ]
27 * Support for translations of installed apps. (LP: #1237992) Fix
28 translations not being installed. (LP: #1316802) Fix merge of
29 translations to clickscope.ini. (LP: #1316778) Strip full path from
30 translations and template. (LP: #1316777) Enable submission of
31 reviews from the installed preview. (LP: #1237992, #1316777,
32 #1316802, #1316778)
33
34 -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Thu, 08 May 2014 18:24:59 +0000
35
1unity-scope-click (0.1+14.10.20140506-0ubuntu1) utopic; urgency=low36unity-scope-click (0.1+14.10.20140506-0ubuntu1) utopic; urgency=low
237
3 [ Alejandro J. Cura ]38 [ Alejandro J. Cura ]
439
=== modified file 'scope/tests/test_index.cpp'
--- scope/tests/test_index.cpp 2014-05-14 18:34:20 +0000
+++ scope/tests/test_index.cpp 2014-05-20 18:31:10 +0000
@@ -445,7 +445,7 @@
445 click::Package package = {445 click::Package package = {
446 "org.example.testapp", "Test App", 0.00,446 "org.example.testapp", "Test App", 0.00,
447 "/tmp/foo.png",447 "/tmp/foo.png",
448 "", "0.1.5"448 "uri", "0.1.5"
449 };449 };
450 std::string expected = "pkcon -p remove org.example.testapp;0.1.5;all;local:click";450 std::string expected = "pkcon -p remove org.example.testapp;0.1.5;all;local:click";
451 EXPECT_CALL(*this, execute_uninstall_command(expected, _)).Times(1);451 EXPECT_CALL(*this, execute_uninstall_command(expected, _)).Times(1);
452452
=== modified file 'scope/tests/test_query.cpp'
--- scope/tests/test_query.cpp 2014-05-14 18:34:20 +0000
+++ scope/tests/test_query.cpp 2014-05-20 18:31:10 +0000
@@ -159,7 +159,7 @@
159TEST(QueryTest, testAddAvailableAppsPushesResults)159TEST(QueryTest, testAddAvailableAppsPushesResults)
160{160{
161 click::PackageList packages {161 click::PackageList packages {
162 {"name", "title", 0.0, "", ""}162 {"name", "title", 0.0, "icon", "uri"}
163 };163 };
164 MockIndex mock_index(packages);164 MockIndex mock_index(packages);
165 scopes::SearchMetadata metadata("en_EN", "phone");165 scopes::SearchMetadata metadata("en_EN", "phone");
@@ -181,7 +181,7 @@
181TEST(QueryTest, testAddAvailableAppsCallsFinished)181TEST(QueryTest, testAddAvailableAppsCallsFinished)
182{182{
183 click::PackageList packages {183 click::PackageList packages {
184 {"name", "title", 0.0, "", ""}184 {"name", "title", 0.0, "icon", "uri"}
185 };185 };
186 MockIndex mock_index(packages);186 MockIndex mock_index(packages);
187 scopes::SearchMetadata metadata("en_EN", "phone");187 scopes::SearchMetadata metadata("en_EN", "phone");
@@ -202,7 +202,7 @@
202TEST(QueryTest, testAddAvailableAppsWithNullCategory)202TEST(QueryTest, testAddAvailableAppsWithNullCategory)
203{203{
204 click::PackageList packages {204 click::PackageList packages {
205 {"name", "title", 0.0, "", ""}205 {"name", "title", 0.0, "icon", "uri"}
206 };206 };
207 MockIndex mock_index(packages);207 MockIndex mock_index(packages);
208 scopes::SearchMetadata metadata("en_EN", "phone");208 scopes::SearchMetadata metadata("en_EN", "phone");
@@ -221,7 +221,7 @@
221TEST(QueryTest, testQueryRunCallsAddAvailableApps)221TEST(QueryTest, testQueryRunCallsAddAvailableApps)
222{222{
223 click::PackageList packages {223 click::PackageList packages {
224 {"name", "title", 0.0, "", ""}224 {"name", "title", 0.0, "icon", "uri"}
225 };225 };
226 MockIndex mock_index(packages);226 MockIndex mock_index(packages);
227 scopes::SearchMetadata metadata("en_EN", "phone");227 scopes::SearchMetadata metadata("en_EN", "phone");
@@ -240,8 +240,8 @@
240TEST(QueryTest, testDuplicatesFilteredOnPackageName)240TEST(QueryTest, testDuplicatesFilteredOnPackageName)
241{241{
242 click::PackageList packages {242 click::PackageList packages {
243 {"org.example.app1", "app title1", 0.0, "", ""},243 {"org.example.app1", "app title1", 0.0, "icon", "uri"},
244 {"org.example.app2", "app title2", 0.0, "", ""}244 {"org.example.app2", "app title2", 0.0, "icon", "uri"}
245 };245 };
246 MockIndex mock_index(packages);246 MockIndex mock_index(packages);
247 scopes::SearchMetadata metadata("en_EN", "phone");247 scopes::SearchMetadata metadata("en_EN", "phone");

Subscribers

People subscribed via source and target branches

to all changes: