Merge lp:~dobey/unity-scope-click/merge-trunk into lp:unity-scope-click/devel

Proposed by dobey
Status: Merged
Approved by: dobey
Approved revision: no longer in the source branch.
Merged at revision: 264
Proposed branch: lp:~dobey/unity-scope-click/merge-trunk
Merge into: lp:unity-scope-click/devel
Diff against target: 106 lines (+42/-7)
3 files modified
debian/changelog (+35/-0)
scope/tests/test_index.cpp (+1/-1)
scope/tests/test_query.cpp (+6/-6)
To merge this branch: bzr merge lp:~dobey/unity-scope-click/merge-trunk
Reviewer Review Type Date Requested Status
dobey (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+220316@code.launchpad.net

Commit message

Merge release revisions from trunk back to devel.
Don't use empty strings for the icon and app URIs in the tests.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
dobey (dobey) :
review: Approve
264. By dobey

Merge release revisions from trunk back to devel.
Don't use empty strings for the icon and app URIs in the tests.

Approved by Rodney Dawes, PS Jenkins bot.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2014-05-06 17:24:10 +0000
3+++ debian/changelog 2014-05-20 18:31:10 +0000
4@@ -1,3 +1,38 @@
5+unity-scope-click (0.1+14.10.20140520-0ubuntu1) utopic; urgency=low
6+
7+ [ Rodney Dawes ]
8+ * Don't use empty strings for the icon and app URIs in the tests. (LP:
9+ #1321312)
10+
11+ -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Tue, 20 May 2014 14:57:40 +0000
12+
13+unity-scope-click (0.1+14.10.20140516-0ubuntu1) utopic; urgency=low
14+
15+ [ Rodney Dawes ]
16+ * Improve the text in the uninstall confirmation dialog per latest
17+ design. (LP: #1234211). Reorder the header and screenshots to more
18+ closely match the new design. Translations updates. Update autopilot
19+ tests for some changes in apps and unity8. Log the response body on
20+ network errors. Initial work for splitting scope per new designs.
21+ Support running unit tests under valgrind. (LP: #1234211)
22+
23+ -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Fri, 16 May 2014 15:34:59 +0000
24+
25+unity-scope-click (0.1+14.10.20140508.1-0ubuntu1) utopic; urgency=low
26+
27+ [ Ubuntu daily release ]
28+ * New rebuild forced
29+
30+ [ Rodney Dawes ]
31+ * Support for translations of installed apps. (LP: #1237992) Fix
32+ translations not being installed. (LP: #1316802) Fix merge of
33+ translations to clickscope.ini. (LP: #1316778) Strip full path from
34+ translations and template. (LP: #1316777) Enable submission of
35+ reviews from the installed preview. (LP: #1237992, #1316777,
36+ #1316802, #1316778)
37+
38+ -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Thu, 08 May 2014 18:24:59 +0000
39+
40 unity-scope-click (0.1+14.10.20140506-0ubuntu1) utopic; urgency=low
41
42 [ Alejandro J. Cura ]
43
44=== modified file 'scope/tests/test_index.cpp'
45--- scope/tests/test_index.cpp 2014-05-14 18:34:20 +0000
46+++ scope/tests/test_index.cpp 2014-05-20 18:31:10 +0000
47@@ -445,7 +445,7 @@
48 click::Package package = {
49 "org.example.testapp", "Test App", 0.00,
50 "/tmp/foo.png",
51- "", "0.1.5"
52+ "uri", "0.1.5"
53 };
54 std::string expected = "pkcon -p remove org.example.testapp;0.1.5;all;local:click";
55 EXPECT_CALL(*this, execute_uninstall_command(expected, _)).Times(1);
56
57=== modified file 'scope/tests/test_query.cpp'
58--- scope/tests/test_query.cpp 2014-05-14 18:34:20 +0000
59+++ scope/tests/test_query.cpp 2014-05-20 18:31:10 +0000
60@@ -159,7 +159,7 @@
61 TEST(QueryTest, testAddAvailableAppsPushesResults)
62 {
63 click::PackageList packages {
64- {"name", "title", 0.0, "", ""}
65+ {"name", "title", 0.0, "icon", "uri"}
66 };
67 MockIndex mock_index(packages);
68 scopes::SearchMetadata metadata("en_EN", "phone");
69@@ -181,7 +181,7 @@
70 TEST(QueryTest, testAddAvailableAppsCallsFinished)
71 {
72 click::PackageList packages {
73- {"name", "title", 0.0, "", ""}
74+ {"name", "title", 0.0, "icon", "uri"}
75 };
76 MockIndex mock_index(packages);
77 scopes::SearchMetadata metadata("en_EN", "phone");
78@@ -202,7 +202,7 @@
79 TEST(QueryTest, testAddAvailableAppsWithNullCategory)
80 {
81 click::PackageList packages {
82- {"name", "title", 0.0, "", ""}
83+ {"name", "title", 0.0, "icon", "uri"}
84 };
85 MockIndex mock_index(packages);
86 scopes::SearchMetadata metadata("en_EN", "phone");
87@@ -221,7 +221,7 @@
88 TEST(QueryTest, testQueryRunCallsAddAvailableApps)
89 {
90 click::PackageList packages {
91- {"name", "title", 0.0, "", ""}
92+ {"name", "title", 0.0, "icon", "uri"}
93 };
94 MockIndex mock_index(packages);
95 scopes::SearchMetadata metadata("en_EN", "phone");
96@@ -240,8 +240,8 @@
97 TEST(QueryTest, testDuplicatesFilteredOnPackageName)
98 {
99 click::PackageList packages {
100- {"org.example.app1", "app title1", 0.0, "", ""},
101- {"org.example.app2", "app title2", 0.0, "", ""}
102+ {"org.example.app1", "app title1", 0.0, "icon", "uri"},
103+ {"org.example.app2", "app title2", 0.0, "icon", "uri"}
104 };
105 MockIndex mock_index(packages);
106 scopes::SearchMetadata metadata("en_EN", "phone");

Subscribers

People subscribed via source and target branches

to all changes: