Merge lp:~dobey/unity-scope-click/explicit-pthread into lp:unity-scope-click

Proposed by dobey
Status: Merged
Approved by: Alejandro J. Cura
Approved revision: 266
Merged at revision: 265
Proposed branch: lp:~dobey/unity-scope-click/explicit-pthread
Merge into: lp:unity-scope-click
Diff against target: 22 lines (+4/-2)
1 file modified
tools/init-departments/CMakeLists.txt (+4/-2)
To merge this branch: bzr merge lp:~dobey/unity-scope-click/explicit-pthread
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Alejandro J. Cura (community) Approve
Review via email: mp+230973@code.launchpad.net

Commit message

New libstdc++ requires explicit -lpthread when using std::thread.

To post a comment you must log in.
266. By dobey

Use the cmake thread libs variable instead.

Revision history for this message
Alejandro J. Cura (alecu) wrote :

Code looks good, have not tested it.

review: Approve
267. By dobey

Also need the find_package(Threads) in the init-departments CMakeLists.txt.

Revision history for this message
Adam Conrad (adconrad) wrote :

Tested r267, and it does the right thing.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tools/init-departments/CMakeLists.txt'
--- tools/init-departments/CMakeLists.txt 2014-07-14 09:43:27 +0000
+++ tools/init-departments/CMakeLists.txt 2014-08-15 14:03:54 +0000
@@ -2,6 +2,7 @@
2set (INITDEPTS init-departments)2set (INITDEPTS init-departments)
33
4find_package (Qt5Core REQUIRED)4find_package (Qt5Core REQUIRED)
5find_package (Threads)
56
6include_directories (7include_directories (
7 ${CMAKE_SOURCE_DIR}/libclickscope8 ${CMAKE_SOURCE_DIR}/libclickscope
@@ -15,7 +16,8 @@
15qt5_use_modules (${INITDEPTS} Network Sql)16qt5_use_modules (${INITDEPTS} Network Sql)
1617
17target_link_libraries(${INITDEPTS}18target_link_libraries(${INITDEPTS}
18 ${SCOPE_LIB_NAME}19 ${SCOPE_LIB_NAME}
19 )20 ${CMAKE_THREAD_LIBS_INIT}
21)
2022
21install(TARGETS ${INITDEPTS} DESTINATION sbin)23install(TARGETS ${INITDEPTS} DESTINATION sbin)

Subscribers

People subscribed via source and target branches

to all changes: