Merge lp:~dobey/ubuntuone-installer/learn-more into lp:ubuntuone-installer

Proposed by dobey
Status: Merged
Approved by: dobey
Approved revision: 10
Merged at revision: 14
Proposed branch: lp:~dobey/ubuntuone-installer/learn-more
Merge into: lp:ubuntuone-installer
Diff against target: 26 lines (+7/-2)
1 file modified
ubuntuone/installer/gui.py (+7/-2)
To merge this branch: bzr merge lp:~dobey/ubuntuone-installer/learn-more
Reviewer Review Type Date Requested Status
Roberto Alsina (community) Approve
Review via email: mp+72086@code.launchpad.net

Commit message

Add a link button to point to the web site, labelled "Learn more"
Change the install button text to just be Install

To post a comment you must log in.
Revision history for this message
Roberto Alsina (ralsina) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'ubuntuone/installer/gui.py'
--- ubuntuone/installer/gui.py 2011-08-16 17:45:44 +0000
+++ ubuntuone/installer/gui.py 2011-08-18 18:16:38 +0000
@@ -97,8 +97,7 @@
97 self.__action_area.add(self.__cancel_button)97 self.__action_area.add(self.__cancel_button)
98 self.__cancel_button.show()98 self.__cancel_button.show()
9999
100 self.__main_button = Gtk.Button.new_with_mnemonic(100 self.__main_button = Gtk.Button.new_with_mnemonic('I_nstall')
101 'I_nstall Ubuntu One')
102 self.__main_button.set_image(Gtk.Image.new_from_stock(101 self.__main_button.set_image(Gtk.Image.new_from_stock(
103 Gtk.STOCK_OK, Gtk.IconSize.BUTTON))102 Gtk.STOCK_OK, Gtk.IconSize.BUTTON))
104 self.__main_button.connect('clicked', lambda x: self.emit(103 self.__main_button.connect('clicked', lambda x: self.emit(
@@ -107,6 +106,12 @@
107 self.__main_button.grab_focus()106 self.__main_button.grab_focus()
108 self.__main_button.show()107 self.__main_button.show()
109108
109 self.__lm_button = Gtk.LinkButton.new_with_label(
110 'https://one.ubuntu.com/', 'Learn more')
111 self.__action_area.add(self.__lm_button)
112 self.__action_area.set_child_secondary(self.__lm_button, True)
113 self.__lm_button.show()
114
110 self.connect('destroy', self.destroyed)115 self.connect('destroy', self.destroyed)
111 self.connect('response', self.__got_response)116 self.connect('response', self.__got_response)
112 self.connect('delete-event', lambda x, y: self.emit(117 self.connect('delete-event', lambda x, y: self.emit(

Subscribers

People subscribed via source and target branches

to all changes: