Code review comment for lp:~dobey/ubuntuone-dev-tools/updates-2992

Revision history for this message
Brian Curtin (brian.curtin) wrote :

Minor issue: In your uses of subprocess.Popen, you open stdout and stderr but don't close them.

Otherwise: +1

review: Approve

« Back to merge proposal