Code review comment for lp:~dobey/ubuntuone-credentials/fix-cancel

Revision history for this message
Alberto Mardegan (mardy) wrote :

I found out what's wrong when the plugin is called from an application (such as the dash): the sync() method is called too early.
It should be called only once, but only when the plugin has finished writing stuff into the account. While this branch improves things by reducing the number of times sync() is being called, it doesn't call sync after _account->setCredentialsId(id) has been called. This results in the account being created with a "credentialsId" field set to 0, and therefore there's no link between the account and the SignOn::Identity objects.

review: Needs Fixing

« Back to merge proposal