Merge lp:~dobey/ubuntuone-control-panel/update-13-10 into lp:ubuntuone-control-panel/stable-13-10

Proposed by dobey
Status: Merged
Approved by: dobey
Approved revision: no longer in the source branch.
Merged at revision: 404
Proposed branch: lp:~dobey/ubuntuone-control-panel/update-13-10
Merge into: lp:ubuntuone-control-panel/stable-13-10
Diff against target: 21 lines (+2/-4)
1 file modified
ubuntuone/controlpanel/gui/__init__.py (+2/-4)
To merge this branch: bzr merge lp:~dobey/ubuntuone-control-panel/update-13-10
Reviewer Review Type Date Requested Status
Roberto Alsina (community) Approve
Review via email: mp+172906@code.launchpad.net

Commit message

[Rodney Dawes]

    Don't import APP_NAME from ubuntuone.clientdefs. Get it from SSO now.

To post a comment you must log in.
Revision history for this message
Roberto Alsina (ralsina) :
review: Approve
Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :

The attempt to merge lp:~dobey/ubuntuone-control-panel/update-13-10 into lp:ubuntuone-control-panel/stable-13-10 failed. Below is the output from the failed tests.

*** Running DBus test suite ***

Traceback (most recent call last):
  File "/usr/bin/u1trial", line 40, in <module>
    main()
  File "/usr/lib/python2.7/dist-packages/ubuntuone-dev-tools/ubuntuone/devtools/runners/__init__.py", line 274, in main
    options.parseOptions()
  File "/usr/lib/python2.7/dist-packages/twisted/python/usage.py", line 272, in parseOptions
    self.parseArgs(*args)
  File "/usr/lib/python2.7/dist-packages/twisted/scripts/trial.py", line 272, in parseArgs
    self['tests'].extend(args)
AttributeError: 'set' object has no attribute 'extend'

Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :

The attempt to merge lp:~dobey/ubuntuone-control-panel/update-13-10 into lp:ubuntuone-control-panel/stable-13-10 failed. Below is the output from the failed tests.

*** Running DBus test suite ***

Traceback (most recent call last):
  File "/usr/bin/u1trial", line 40, in <module>
    main()
  File "/usr/lib/python2.7/dist-packages/ubuntuone-dev-tools/ubuntuone/devtools/runners/__init__.py", line 274, in main
    options.parseOptions()
  File "/usr/lib/python2.7/dist-packages/twisted/python/usage.py", line 272, in parseOptions
    self.parseArgs(*args)
  File "/usr/lib/python2.7/dist-packages/twisted/scripts/trial.py", line 272, in parseArgs
    self['tests'].extend(args)
AttributeError: 'set' object has no attribute 'extend'

404. By dobey

[Rodney Dawes]

    Don't import APP_NAME from ubuntuone.clientdefs. Get it from SSO now.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'ubuntuone/controlpanel/gui/__init__.py'
--- ubuntuone/controlpanel/gui/__init__.py 2012-12-11 19:04:12 +0000
+++ ubuntuone/controlpanel/gui/__init__.py 2013-07-03 20:58:26 +0000
@@ -1,6 +1,6 @@
1# -*- coding: utf-8 -*-1# -*- coding: utf-8 -*-
2#2#
3# Copyright 2011-2012 Canonical Ltd.3# Copyright 2011-2013 Canonical Ltd.
4#4#
5# This program is free software: you can redistribute it and/or modify it5# This program is free software: you can redistribute it and/or modify it
6# under the terms of the GNU General Public License version 3, as published6# under the terms of the GNU General Public License version 3, as published
@@ -18,9 +18,7 @@
1818
19import os19import os
2020
21# pylint: disable=W061121from ubuntu_sso.constants import APP_NAME
22from ubuntuone.clientdefs import APP_NAME
23# pylint: enable=W0611
2422
25from ubuntu_sso.utils.translation import get_gettext23from ubuntu_sso.utils.translation import get_gettext
2624

Subscribers

People subscribed via source and target branches

to all changes: