Code review comment for lp:~dobey/ubuntuone-control-panel/lint-roller

Revision history for this message
Mike McCracken (mikemc) wrote :

With the changes from sso lint-roller, controlpanel.backend is importing something from the wrong place now: it needs to be 'from ubuntu_sso.utils.webclient.common import UnauthorizedError, etc'

Traceback (most recent call last):
  File "/Users/mmccrack/Documents/Canonical/Source/test-improve-buildout/scripts/devsetup/bin/u1trial", line 40, in <module>
    ubuntuone.devtools.runners.main()
  File "/Users/mmccrack/Documents/Canonical/Source/test-improve-buildout/scripts/devsetup/parts/ubuntuone-dev-tools/ubuntuone/devtools/runners/__init__.py", line 277, in main
    suite = test_runner.get_suite(options)
  File "/Users/mmccrack/Documents/Canonical/Source/test-improve-buildout/scripts/devsetup/parts/ubuntuone-dev-tools/ubuntuone/devtools/runners/__init__.py", line 173, in get_suite
    config['ignore-paths']))
  File "/Users/mmccrack/Documents/Canonical/Source/test-improve-buildout/scripts/devsetup/parts/ubuntuone-dev-tools/ubuntuone/devtools/runners/__init__.py", line 157, in _collect_tests
    module_suite = self._load_unittest(filepath)
  File "/Users/mmccrack/Documents/Canonical/Source/test-improve-buildout/scripts/devsetup/parts/ubuntuone-dev-tools/ubuntuone/devtools/runners/__init__.py", line 98, in _load_unittest
    module = __import__(modpath, None, None, [""])
  File "/Users/mmccrack/Documents/Canonical/Source/test-improve-buildout/scripts/devsetup/parts/ubuntuone-control-panel/ubuntuone/controlpanel/gui/__init__.py", line 27, in <module>
    from ubuntuone.controlpanel.backend import UBUNTUONE_LINK
  File "/Users/mmccrack/Documents/Canonical/Source/test-improve-buildout/scripts/devsetup/parts/ubuntuone-control-panel/ubuntuone/controlpanel/backend.py", line 34, in <module>
    from ubuntu_sso.utils.webclient import UnauthorizedError, WebClientError
ImportError: cannot import name UnauthorizedError

review: Needs Fixing

« Back to merge proposal