Merge lp:~dobey/ubuntuone-client/grrrr-gir-4-0 into lp:ubuntuone-client/stable-4-0

Proposed by dobey
Status: Merged
Merged at revision: 1267
Proposed branch: lp:~dobey/ubuntuone-client/grrrr-gir-4-0
Merge into: lp:ubuntuone-client/stable-4-0
Diff against target: 55 lines (+6/-7)
2 files modified
bin/ubuntuone-launch (+3/-4)
bin/ubuntuone-login (+3/-3)
To merge this branch: bzr merge lp:~dobey/ubuntuone-client/grrrr-gir-4-0
Reviewer Review Type Date Requested Status
Mike McCracken (community) Approve
Diego Sarmentero (community) Approve
Review via email: mp+129904@code.launchpad.net

Commit message

Use GI bindings of GLib instead of static bindings in launch/login scripts.

To post a comment you must log in.
Revision history for this message
Diego Sarmentero (diegosarmentero) wrote :

+1

review: Approve
Revision history for this message
Mike McCracken (mikemc) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'bin/ubuntuone-launch'
--- bin/ubuntuone-launch 2012-04-09 20:07:05 +0000
+++ bin/ubuntuone-launch 2012-10-16 14:21:26 +0000
@@ -63,10 +63,9 @@
63 sys.exit(1)63 sys.exit(1)
6464
65import dbus65import dbus
66import glib
67import gobject
6866
69from dbus.mainloop.glib import DBusGMainLoop67from dbus.mainloop.glib import DBusGMainLoop
68from gi.repository import GLib
70from twisted.internet import defer69from twisted.internet import defer
7170
72from ubuntuone.syncdaemon.config import get_user_config71from ubuntuone.syncdaemon.config import get_user_config
@@ -76,7 +75,7 @@
76@defer.inlineCallbacks75@defer.inlineCallbacks
77def main():76def main():
78 """Start syncdaemon and ask it to connect, if possible."""77 """Start syncdaemon and ask it to connect, if possible."""
79 gobject.set_application_name("ubuntuone-launch")78 GLib.set_application_name("ubuntuone-launch")
8079
81 files_sync_enabled = get_user_config().get_files_sync_enabled()80 files_sync_enabled = get_user_config().get_files_sync_enabled()
82 if not files_sync_enabled:81 if not files_sync_enabled:
@@ -99,5 +98,5 @@
99 # os._exit feels like it's cheating, but it's simple and fast98 # os._exit feels like it's cheating, but it's simple and fast
100 d.addCallbacks(lambda _: os._exit(0), lambda _: os._exit(1))99 d.addCallbacks(lambda _: os._exit(0), lambda _: os._exit(1))
101100
102 mainloop = glib.MainLoop()101 mainloop = GLib.MainLoop()
103 mainloop.run()102 mainloop.run()
104103
=== modified file 'bin/ubuntuone-login'
--- bin/ubuntuone-login 2012-06-18 08:48:44 +0000
+++ bin/ubuntuone-login 2012-10-16 14:21:26 +0000
@@ -40,8 +40,8 @@
4040
41import dbus.mainloop.glib41import dbus.mainloop.glib
42import dbus.service42import dbus.service
43import glib
4443
44from gi.repository import GLib
45from ubuntuone.logger import basic_formatter45from ubuntuone.logger import basic_formatter
46from ubuntuone.platform.credentials import logger46from ubuntuone.platform.credentials import logger
47from ubuntuone.platform.credentials.dbus_service import (47from ubuntuone.platform.credentials.dbus_service import (
@@ -70,8 +70,8 @@
7070
71 logger.info("Starting Ubuntu One login manager for bus %r.", DBUS_BUS_NAME)71 logger.info("Starting Ubuntu One login manager for bus %r.", DBUS_BUS_NAME)
72 bus_name = dbus.service.BusName(DBUS_BUS_NAME, bus=dbus.SessionBus())72 bus_name = dbus.service.BusName(DBUS_BUS_NAME, bus=dbus.SessionBus())
73 mainloop = glib.MainLoop()73 mainloop = GLib.MainLoop()
74 CredentialsManagement(timeout_func=glib.timeout_add,74 CredentialsManagement(timeout_func=GLib.timeout_add,
75 shutdown_func=mainloop.quit,75 shutdown_func=mainloop.quit,
76 bus_name=bus_name, object_path=DBUS_CREDENTIALS_PATH)76 bus_name=bus_name, object_path=DBUS_CREDENTIALS_PATH)
7777

Subscribers

People subscribed via source and target branches

to all changes: