Merge lp:~dobey/ubuntuone-client/fix-570721 into lp:ubuntuone-client

Proposed by dobey
Status: Merged
Approved by: Vincenzo Di Somma
Approved revision: 513
Merged at revision: not available
Proposed branch: lp:~dobey/ubuntuone-client/fix-570721
Merge into: lp:ubuntuone-client
Diff against target: 37 lines (+3/-2)
3 files modified
bin/ubuntuone-preferences (+1/-1)
ubuntuone/syncdaemon/dbus_interface.py (+1/-1)
ubuntuone/syncdaemon/tools.py (+1/-0)
To merge this branch: bzr merge lp:~dobey/ubuntuone-client/fix-570721
Reviewer Review Type Date Requested Status
Vincenzo Di Somma (community) Approve
Rodrigo Moya (community) Approve
Review via email: mp+24456@code.launchpad.net

Commit message

Fix typo in music_check_toggled call (removed preceding __)
Convert the DBusBool '0' to int then Python bool for storing
Update the internal config object with the new value after calling DBus

To post a comment you must log in.
Revision history for this message
Rodrigo Moya (rodrigo-moya) wrote :

Looks good

review: Approve
Revision history for this message
Vincenzo Di Somma (vds) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'bin/ubuntuone-preferences'
--- bin/ubuntuone-preferences 2010-04-21 18:54:16 +0000
+++ bin/ubuntuone-preferences 2010-04-29 21:17:19 +0000
@@ -802,7 +802,7 @@
802 if self.ums_id:802 if self.ums_id:
803 self.music_check.set_sensitive(True)803 self.music_check.set_sensitive(True)
804 if self.music_check.get_active():804 if self.music_check.get_active():
805 self.__music_check_toggled(self.music_check)805 self.music_check_toggled(self.music_check)
806 else:806 else:
807 self.sdtool.quit().addCallback(807 self.sdtool.quit().addCallback(
808 lambda _: self.devices.list_devices())808 lambda _: self.devices.list_devices())
809809
=== modified file 'ubuntuone/syncdaemon/dbus_interface.py'
--- ubuntuone/syncdaemon/dbus_interface.py 2010-04-09 18:21:13 +0000
+++ ubuntuone/syncdaemon/dbus_interface.py 2010-04-29 21:17:19 +0000
@@ -1214,7 +1214,7 @@
1214 """Enable UDF autosubscribe."""1214 """Enable UDF autosubscribe."""
1215 logger.debug('called set_files_sync_enabled %d', enabled)1215 logger.debug('called set_files_sync_enabled %d', enabled)
1216 user_config = config.get_user_config()1216 user_config = config.get_user_config()
1217 user_config.set_files_sync_enabled(enabled)1217 user_config.set_files_sync_enabled(bool(int(enabled)))
1218 user_config.save()1218 user_config.save()
12191219
1220 @dbus.service.method(DBUS_IFACE_CONFIG_NAME,1220 @dbus.service.method(DBUS_IFACE_CONFIG_NAME,
12211221
=== modified file 'ubuntuone/syncdaemon/tools.py'
--- ubuntuone/syncdaemon/tools.py 2010-04-14 19:01:12 +0000
+++ ubuntuone/syncdaemon/tools.py 2010-04-29 21:17:19 +0000
@@ -719,6 +719,7 @@
719 enabled,719 enabled,
720 reply_handler=d.callback,720 reply_handler=d.callback,
721 error_handler=d.errback)721 error_handler=d.errback)
722 config.set_files_sync_enabled(False)
722 return d723 return d
723 else:724 else:
724 if enabled:725 if enabled:

Subscribers

People subscribed via source and target branches