Code review comment for lp:~dobey/ubuntu/precise/ubuntuone-dev-tools/release-2-99-2

Revision history for this message
Charlie_Smotherman (cjsmo) wrote :

Looks good except for a few nit pics.

in debian/rules "dh --with python2 $@" should be "dh $@ --with python2

And some lintian errors that need to be addressed

W: ubuntuone-dev-tools source: brace-expansion-in-debhelper-config-file debian/ubuntuone-dev-tools.install
N:
N: This debhelper config file appears to use shell brace expansion (such as
N: {foo,bar}) to specify files. This happens to work due to an accident of
N: implementation but is not a supported feature. Only ?, *, and [...] are
N: supported.
N:
N: Refer to the debhelper(1) manual page for details.
N:
N: Severity: normal, Certainty: possible
N:
N: Check: debhelper, Type: source
N:
W: ubuntuone-dev-tools source: obsolete-field-in-dep5-copyright format-specification format
N:
N: The machine-readable copyright file uses a field, that used to be
N: defined by the specification, but has been renamed since then.
N:
N: Please use Format instead of Format-Specification.
N:
N: Please use Upstream-Contact instead of Contact, Maintainer or
N: Upstream-Maintainer.
N:
N: Please use Upstream-Name instead of Name.
N:
N: Refer to http://dep.debian.net/deps/dep5/ for details.
N:
N: Severity: normal, Certainty: possible
N:
N: Check: source-copyright, Type: source
N:

« Back to merge proposal