Merge lp:~dobey/ubuntu/lucid/ubuntuone-client/fix-567223 into lp:ubuntu/lucid/ubuntuone-client

Proposed by dobey
Status: Merged
Merged at revision: not available
Proposed branch: lp:~dobey/ubuntu/lucid/ubuntuone-client/fix-567223
Merge into: lp:ubuntu/lucid/ubuntuone-client
Diff against target: 53 lines (+30/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/fix-567223.patch (+22/-0)
debian/rules (+1/-0)
To merge this branch: bzr merge lp:~dobey/ubuntu/lucid/ubuntuone-client/fix-567223
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+23879@code.launchpad.net

Description of the change

Quick patch to fix #567223. Already approved/committed upstream.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2010-04-20 14:43:08 +0000
+++ debian/changelog 2010-04-21 20:44:17 +0000
@@ -1,3 +1,10 @@
1ubuntuone-client (1.2.1-0ubuntu2) UNRELEASED; urgency=low
2
3 * Add fix-567223.patch.
4 - Fixes gtk.MODAL usage and dialog closure. (LP: #567223)
5
6 -- Rodney Dawes <rodney.dawes@canonical.com> Wed, 21 Apr 2010 16:38:34 -0400
7
1ubuntuone-client (1.2.1-0ubuntu1) lucid; urgency=low8ubuntuone-client (1.2.1-0ubuntu1) lucid; urgency=low
29
3 * New upstream release.10 * New upstream release.
411
=== added directory 'debian/patches'
=== added file 'debian/patches/fix-567223.patch'
--- debian/patches/fix-567223.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/fix-567223.patch 2010-04-21 20:44:17 +0000
@@ -0,0 +1,22 @@
1=== modified file 'bin/ubuntuone-preferences'
2--- bin/ubuntuone-preferences 2010-04-19 14:37:13 +0000
3+++ bin/ubuntuone-preferences 2010-04-21 18:54:16 +0000
4@@ -301,11 +301,15 @@
5 """
6 logger.error(msg)
7 dialog = gtk.MessageDialog(self.get_toplevel(),
8- gtk.DIALOG_DESTROY_WITH_PARENT | gtk.MODAL,
9+ gtk.DIALOG_DESTROY_WITH_PARENT |
10+ gtk.DIALOG_MODAL,
11 gtk.MESSAGE_ERROR, gtk.BUTTONS_CLOSE,
12 'Error')
13 dialog.format_secondary_text(str(msg))
14- dialog.run()
15+ try:
16+ dialog.run()
17+ finally:
18+ dialog.destroy()
19 while gtk.events_pending():
20 gtk.main_iteration()
21
22
023
=== modified file 'debian/rules'
--- debian/rules 2010-04-19 21:24:37 +0000
+++ debian/rules 2010-04-21 20:44:17 +0000
@@ -3,6 +3,7 @@
3DEB_PYTHON_SYSTEM = pycentral3DEB_PYTHON_SYSTEM = pycentral
44
5include /usr/share/cdbs/1/rules/debhelper.mk5include /usr/share/cdbs/1/rules/debhelper.mk
6include /usr/share/cdbs/1/rules/simple-patchsys.mk
6include /usr/share/cdbs/1/rules/utils.mk7include /usr/share/cdbs/1/rules/utils.mk
7include /usr/share/cdbs/1/class/gnome.mk8include /usr/share/cdbs/1/class/gnome.mk
89

Subscribers

People subscribed via source and target branches

to all changes: