Merge lp:~dobey/ubuntu/lucid/ubuntuone-client/fix-567223 into lp:ubuntu/lucid/ubuntuone-client

Proposed by dobey
Status: Merged
Merged at revision: not available
Proposed branch: lp:~dobey/ubuntu/lucid/ubuntuone-client/fix-567223
Merge into: lp:ubuntu/lucid/ubuntuone-client
Diff against target: 53 lines (+30/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/fix-567223.patch (+22/-0)
debian/rules (+1/-0)
To merge this branch: bzr merge lp:~dobey/ubuntu/lucid/ubuntuone-client/fix-567223
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+23879@code.launchpad.net

Description of the change

Quick patch to fix #567223. Already approved/committed upstream.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2010-04-20 14:43:08 +0000
3+++ debian/changelog 2010-04-21 20:44:17 +0000
4@@ -1,3 +1,10 @@
5+ubuntuone-client (1.2.1-0ubuntu2) UNRELEASED; urgency=low
6+
7+ * Add fix-567223.patch.
8+ - Fixes gtk.MODAL usage and dialog closure. (LP: #567223)
9+
10+ -- Rodney Dawes <rodney.dawes@canonical.com> Wed, 21 Apr 2010 16:38:34 -0400
11+
12 ubuntuone-client (1.2.1-0ubuntu1) lucid; urgency=low
13
14 * New upstream release.
15
16=== added directory 'debian/patches'
17=== added file 'debian/patches/fix-567223.patch'
18--- debian/patches/fix-567223.patch 1970-01-01 00:00:00 +0000
19+++ debian/patches/fix-567223.patch 2010-04-21 20:44:17 +0000
20@@ -0,0 +1,22 @@
21+=== modified file 'bin/ubuntuone-preferences'
22+--- bin/ubuntuone-preferences 2010-04-19 14:37:13 +0000
23++++ bin/ubuntuone-preferences 2010-04-21 18:54:16 +0000
24+@@ -301,11 +301,15 @@
25+ """
26+ logger.error(msg)
27+ dialog = gtk.MessageDialog(self.get_toplevel(),
28+- gtk.DIALOG_DESTROY_WITH_PARENT | gtk.MODAL,
29++ gtk.DIALOG_DESTROY_WITH_PARENT |
30++ gtk.DIALOG_MODAL,
31+ gtk.MESSAGE_ERROR, gtk.BUTTONS_CLOSE,
32+ 'Error')
33+ dialog.format_secondary_text(str(msg))
34+- dialog.run()
35++ try:
36++ dialog.run()
37++ finally:
38++ dialog.destroy()
39+ while gtk.events_pending():
40+ gtk.main_iteration()
41+
42+
43
44=== modified file 'debian/rules'
45--- debian/rules 2010-04-19 21:24:37 +0000
46+++ debian/rules 2010-04-21 20:44:17 +0000
47@@ -3,6 +3,7 @@
48 DEB_PYTHON_SYSTEM = pycentral
49
50 include /usr/share/cdbs/1/rules/debhelper.mk
51+include /usr/share/cdbs/1/rules/simple-patchsys.mk
52 include /usr/share/cdbs/1/rules/utils.mk
53 include /usr/share/cdbs/1/class/gnome.mk
54

Subscribers

People subscribed via source and target branches

to all changes: