Merge lp:~dobey/ubuntu-sso-client/fix-urlerror into lp:ubuntu-sso-client

Proposed by dobey
Status: Merged
Approved by: dobey
Approved revision: 729
Merged at revision: 727
Proposed branch: lp:~dobey/ubuntu-sso-client/fix-urlerror
Merge into: lp:ubuntu-sso-client
Diff against target: 38 lines (+5/-2)
2 files modified
ubuntu_sso/qt/tests/show_gui.py (+3/-0)
ubuntu_sso/tests/test_account.py (+2/-2)
To merge this branch: bzr merge lp:~dobey/ubuntu-sso-client/fix-urlerror
Reviewer Review Type Date Requested Status
Natalia Bidart (community) Approve
Review via email: mp+66392@code.launchpad.net

Commit message

Don't put 3 slashes in file URL when appending full path

To post a comment you must log in.
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Thanks for the work on this.

While you're it, can you please fix this faulty docstring?

"""Return a fix captcha)."""

review: Approve
729. By dobey

Fix the docstring as well

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'ubuntu_sso/qt/tests/show_gui.py'
--- ubuntu_sso/qt/tests/show_gui.py 2011-06-23 15:58:26 +0000
+++ ubuntu_sso/qt/tests/show_gui.py 2011-06-30 00:31:31 +0000
@@ -23,11 +23,13 @@
23from twisted.internet.defer import inlineCallbacks23from twisted.internet.defer import inlineCallbacks
24from ubuntu_sso.main.windows import UbuntuSSOClient24from ubuntu_sso.main.windows import UbuntuSSOClient
2525
26
26def found(*args):27def found(*args):
27 """The credentials were found."""28 """The credentials were found."""
28 print "creds found", args29 print "creds found", args
29 reactor.stop()30 reactor.stop()
3031
32
31@inlineCallbacks33@inlineCallbacks
32def main():34def main():
33 """Perform a client request to be logged in."""35 """Perform a client request to be logged in."""
@@ -40,6 +42,7 @@
40 'This is a test.', 0)42 'This is a test.', 0)
41 print "called ok"43 print "called ok"
4244
45
43if __name__ == '__main__':46if __name__ == '__main__':
44 main()47 main()
45 reactor.run()48 reactor.run()
4649
=== modified file 'ubuntu_sso/tests/test_account.py'
--- ubuntu_sso/tests/test_account.py 2011-03-30 11:20:02 +0000
+++ ubuntu_sso/tests/test_account.py 2011-06-30 00:31:31 +0000
@@ -51,8 +51,8 @@
51 """Fake the captcha generator."""51 """Fake the captcha generator."""
5252
53 def new(self):53 def new(self):
54 """Return a fix captcha)."""54 """Return a local fake captcha."""
55 return {'image_url': 'file:///%s' % CAPTCHA_PATH,55 return {'image_url': 'file://%s' % CAPTCHA_PATH,
56 'captcha_id': CAPTCHA_ID}56 'captcha_id': CAPTCHA_ID}
5757
5858

Subscribers

People subscribed via source and target branches