Merge lp:~dobey/ubuntu-sso-client/fix-urlerror into lp:ubuntu-sso-client

Proposed by dobey
Status: Merged
Approved by: dobey
Approved revision: 729
Merged at revision: 727
Proposed branch: lp:~dobey/ubuntu-sso-client/fix-urlerror
Merge into: lp:ubuntu-sso-client
Diff against target: 38 lines (+5/-2)
2 files modified
ubuntu_sso/qt/tests/show_gui.py (+3/-0)
ubuntu_sso/tests/test_account.py (+2/-2)
To merge this branch: bzr merge lp:~dobey/ubuntu-sso-client/fix-urlerror
Reviewer Review Type Date Requested Status
Natalia Bidart (community) Approve
Review via email: mp+66392@code.launchpad.net

Commit message

Don't put 3 slashes in file URL when appending full path

To post a comment you must log in.
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Thanks for the work on this.

While you're it, can you please fix this faulty docstring?

"""Return a fix captcha)."""

review: Approve
729. By dobey

Fix the docstring as well

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntu_sso/qt/tests/show_gui.py'
2--- ubuntu_sso/qt/tests/show_gui.py 2011-06-23 15:58:26 +0000
3+++ ubuntu_sso/qt/tests/show_gui.py 2011-06-30 00:31:31 +0000
4@@ -23,11 +23,13 @@
5 from twisted.internet.defer import inlineCallbacks
6 from ubuntu_sso.main.windows import UbuntuSSOClient
7
8+
9 def found(*args):
10 """The credentials were found."""
11 print "creds found", args
12 reactor.stop()
13
14+
15 @inlineCallbacks
16 def main():
17 """Perform a client request to be logged in."""
18@@ -40,6 +42,7 @@
19 'This is a test.', 0)
20 print "called ok"
21
22+
23 if __name__ == '__main__':
24 main()
25 reactor.run()
26
27=== modified file 'ubuntu_sso/tests/test_account.py'
28--- ubuntu_sso/tests/test_account.py 2011-03-30 11:20:02 +0000
29+++ ubuntu_sso/tests/test_account.py 2011-06-30 00:31:31 +0000
30@@ -51,8 +51,8 @@
31 """Fake the captcha generator."""
32
33 def new(self):
34- """Return a fix captcha)."""
35- return {'image_url': 'file:///%s' % CAPTCHA_PATH,
36+ """Return a local fake captcha."""
37+ return {'image_url': 'file://%s' % CAPTCHA_PATH,
38 'captcha_id': CAPTCHA_ID}
39
40

Subscribers

People subscribed via source and target branches