Code review comment for lp:~dobey/ubuntu-printing-app/add-notifier-daemon

Revision history for this message
Andrew Hayzen (ahayzen) wrote :

@dobey, would you mind doing a pull of trunk to bring in the new changes?

Also when trying to get this to build in a silo I got "No package 'properties-cpp' found", which suggests the package libproperties-cpp-dev should be added to the build-deps?

Furthermore when discussing with Bill we have a few changes (these can be done in this branch or a further branch):
1) Currently the text in the notification doesn't wrap, so you only see the first part. Both the design specifications show this (#1.2 in [0] and in [1]). Is this a limitation of the notifications in unity8? or an issue in this notifier code?

2) We don't think there is an API yet for adding an entry for the printer queue into the launcher of unity8 when something is printing without launching an app (what design wants). So for now can you show a notification when something is sent to the printer ("Printing on printerName"), as shown in the design #1.1 in [0]

3) If the user clicks on the notification when something is sent to the printer, this should show the queue dialog. I'm currently building the queue dialog in another branch, not decided on the launcher name yet - will let you know (probably something like ubuntu-queue-dialog, or maybe we could have a url-handler call for it?).

0 - https://docs.google.com/document/d/1QaM9B1LGT5Pcun2bTQT_hgRIGHLjvg-qMe8pSbJcuj4/edit?ts=5808916c&pli=1#heading=h.8ddcj8k35qnq
1 - https://wiki.ubuntu.com/Printing#Printing_succeeds

review: Needs Fixing

« Back to merge proposal