Code review comment for lp:~dobey/ubuntu-printing-app/add-notifier-daemon

Revision history for this message
Andrew Hayzen (ahayzen) wrote :

So I've been testing this a bit further and have been able to generate notifications. One thing that I noticed is if the job title is empty then the notification looks a bit strange, it comes up with the following: "" has printed . I'm going to improve the printing app to ensure that it always has some form of title, but I wonder if the notification should also have a fallback ?

« Back to merge proposal