Merge lp:~dobey/tarmac/rm-commit-plug into lp:~ubuntuone-hackers/tarmac/trunk

Proposed by dobey on 2013-01-04
Status: Merged
Approved by: Paul Hummer on 2013-01-04
Approved revision: 426
Merged at revision: 426
Proposed branch: lp:~dobey/tarmac/rm-commit-plug
Merge into: lp:~ubuntuone-hackers/tarmac/trunk
Diff against target: 28 lines (+0/-24)
1 file modified
tarmac/plugins/commit.py (+0/-24)
To merge this branch: bzr merge lp:~dobey/tarmac/rm-commit-plug
Reviewer Review Type Date Requested Status
Paul Hummer (community) 2013-01-04 Approve on 2013-01-04
Review via email: mp+141971@code.launchpad.net

Commit message

Remove the broken commit plug-in.

Description of the change

This removes the plug-in which was added in https://code.launchpad.net/~james-w/tarmac/commit-message/+merge/140555 as it breaks the default commit message handling, isn't enabled via a config option, and duplicates functionality already in the commitmessage plug-in, but doesn't work with multiple reviewers. It also has no license header, or tests.

To post a comment you must log in.
Paul Hummer (rockstar) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== removed file 'tarmac/plugins/commit.py'
2--- tarmac/plugins/commit.py 2012-12-18 20:45:26 +0000
3+++ tarmac/plugins/commit.py 1970-01-01 00:00:00 +0000
4@@ -1,24 +0,0 @@
5-import re
6-
7-from tarmac.hooks import tarmac_hooks
8-from tarmac.plugins import TarmacPlugin
9-
10-
11-class CommitMessage(TarmacPlugin):
12-
13- def run(self, command, target, source, proposal):
14- if not re.match(r'^\[.+?\].*$', proposal.commit_message):
15- params = ["[r=%s]" % proposal.reviewer.name]
16- for bug in proposal.source_branch.linked_bugs:
17- params.append("[bug=%s]" % bug.id)
18-
19- proposal.commit_message = ("%s " % ",".join(params) +
20- proposal.commit_message)
21- self.logger.debug("Setting commit_message to %s",
22- proposal.commit_message)
23- else:
24- self.logger.debug("%s has already right commit message",
25- proposal)
26-
27-tarmac_hooks['tarmac_pre_commit'].hook(CommitMessage(),
28- 'Commit messsage template editor.')

Subscribers

People subscribed via source and target branches

to all changes: