Merge lp:~james-w/tarmac/commit-message into lp:~ubuntuone-hackers/tarmac/trunk

[James Westby]

Hi,

This adds the commit message plugin that CA used to set the [r=<reviewer>] and [bug=] things.

It might not be needed with the template plugin used by u1.

Thanks,

James

[Jonathan Lange (jml)]

Personally, I like the commit messages this gives, and the way it means we could ditch the commit message template boilerplate out of our configs.

Have I mentioned recently how much I hate launchpadlib?

review: Approve

=== added file 'tarmac/plugins/commit.py'
--- tarmac/plugins/commit.py	1970-01-01 00:00:00 +0000
+++ tarmac/plugins/commit.py	2012-12-18 21:25:43 +0000
@@ -0,0 +1,24 @@
+import re
+
+from tarmac.hooks import tarmac_hooks
+from tarmac.plugins import TarmacPlugin
+
+
+class CommitMessage(TarmacPlugin):
+
+    def run(self, command, target, source, proposal):
+        if not re.match(r'^\[.+?\].*$', proposal.commit_message):
+            params = ["[r=%s]" % proposal.reviewer.name]
+            for bug in proposal.source_branch.linked_bugs:
+                params.append("[bug=%s]" % bug.id)
+
+            proposal.commit_message = ("%s " % ",".join(params) +
+                                       proposal.commit_message)
+            self.logger.debug("Setting commit_message to %s",
+                              proposal.commit_message)
+        else:
+            self.logger.debug("%s has already right commit message",
+                              proposal)
+
+tarmac_hooks['tarmac_pre_commit'].hook(CommitMessage(),
+    'Commit messsage template editor.')