Merge lp:~dobey/tarmac/fix-whoami into lp:tarmac
Proposed by
dobey
Status: | Merged |
---|---|
Approved by: | Paul Hummer |
Approved revision: | 357 |
Merged at revision: | 355 |
Proposed branch: | lp:~dobey/tarmac/fix-whoami |
Merge into: | lp:tarmac |
Diff against target: |
159 lines (+24/-14) 4 files modified
tarmac/plugins/tests/test_bugresolver.py (+3/-2) tarmac/plugins/tests/test_recipebuilder.py (+1/-0) tarmac/tests/__init__.py (+7/-2) tarmac/tests/test_branch.py (+13/-10) |
To merge this branch: | bzr merge lp:~dobey/tarmac/fix-whoami |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Paul Hummer | Approve | ||
Gavin Panella (community) | Approve | ||
Review via email: mp+35325@code.launchpad.net |
Commit message
Use bzr's TestCaseInTempDir to avoid bzr whoami errors
Fix a couple more pep8 complaints
To post a comment you must log in.
This works (for me) on Lucid with bzr 2.2 :)
I hope you don't mind, but I had one comment:
+ TestCaseInTempD ir.setUp( self)
TestCaseInTempD ir.setUp( ) uses super(), so I think it would be better
to use it here too. There are several other places where the super
classes are explicitly called and they should probably change too.