pay-ui

Code review comment for lp:~dobey/pay-ui/escape-signed-query

  1. escape-signed-query
  2. Merge into first-branch
Revision history for this message
Charles Kerr (charlesk) wrote :

I'm not sure that this does what we need. QUrl::setQuery appears to only check StrictMode in order to clear out the query if validation fails (http://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/io/qurl.cpp#n2618) so instead of encoding the slash in auth_signature wouldn't this just clear the query altogether?

review: Needs Information

« Back to merge proposal