Merge lp:~dobey/pay-service/fix-staging into lp:pay-service

Proposed by dobey
Status: Merged
Approved by: Charles Kerr
Approved revision: 91
Merged at revision: 94
Proposed branch: lp:~dobey/pay-service/fix-staging
Merge into: lp:pay-service
Diff against target: 17 lines (+3/-2)
1 file modified
tests/setup-staging.sh (+3/-2)
To merge this branch: bzr merge lp:~dobey/pay-service/fix-staging
Reviewer Review Type Date Requested Status
Antti Kaijanmäki (community) Approve
Charles Kerr (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+282316@code.launchpad.net

Commit message

Fix typo in setup-staging.sh.
Also include remounting / in setup-staging.sh to enable writable for key.

To post a comment you must log in.
lp:~dobey/pay-service/fix-staging updated
91. By dobey

Don't remount ro, to avoid ro for people who use writable-image.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) :
review: Approve
Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

LGTM.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tests/setup-staging.sh'
--- tests/setup-staging.sh 2015-10-20 20:18:25 +0000
+++ tests/setup-staging.sh 2016-01-12 15:23:50 +0000
@@ -45,10 +45,11 @@
45STAGING_POLICY_PATH=/etc/debsig/policies/${STAGING_KEY_ID}45STAGING_POLICY_PATH=/etc/debsig/policies/${STAGING_KEY_ID}
4646
47PROD_KEY_ID=608FF2D200A0A71F47PROD_KEY_ID=608FF2D200A0A71F
48PROD_POLCIY_PATH=/etc/debsig/policies/${PROD_KEY_ID}48PROD_POLICY_PATH=/etc/debsig/policies/${PROD_KEY_ID}
4949
50if [ ! -d ${STAGING_KEYRING_PATH} ]; then50if [ ! -d ${STAGING_KEYRING_PATH} -o ! -d ${STAGING_POLICY_PATH} ]; then
51 echo "Setting up staging GPG key"51 echo "Setting up staging GPG key"
52 sudo mount -o remount,rw /
52 sudo mkdir -p ${STAGING_KEYRING_PATH}53 sudo mkdir -p ${STAGING_KEYRING_PATH}
53 sudo gpg --no-default-keyring \54 sudo gpg --no-default-keyring \
54 --keyring ${STAGING_KEYRING_PATH}/click-store.gpg \55 --keyring ${STAGING_KEYRING_PATH}/click-store.gpg \

Subscribers

People subscribed via source and target branches

to all changes: