Merge lp:~dobey/pay-service/fix-script-path into lp:pay-service/14.10

Proposed by dobey
Status: Merged
Approved by: Alejandro J. Cura
Approved revision: 12
Merged at revision: 13
Proposed branch: lp:~dobey/pay-service/fix-script-path
Merge into: lp:pay-service/14.10
Prerequisite: lp:~ted/pay-service/staging-dbus
Diff against target: 47 lines (+11/-9)
2 files modified
debian/control (+2/-0)
tests/setup-staging.sh (+9/-9)
To merge this branch: bzr merge lp:~dobey/pay-service/fix-script-path
Reviewer Review Type Date Requested Status
Alejandro J. Cura (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+225061@code.launchpad.net

Commit message

Recommend libglib2.0-bin and upstart as setup-staging.sh requires them.
Specify the full path to initctl and restart as /sbin is not in $PATH.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alejandro J. Cura (alecu) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/control'
--- debian/control 2014-06-13 17:05:49 +0000
+++ debian/control 2014-06-30 17:32:19 +0000
@@ -31,6 +31,8 @@
31Pre-Depends: ${misc:Pre-Depends},31Pre-Depends: ${misc:Pre-Depends},
32Depends: ${misc:Depends},32Depends: ${misc:Depends},
33 ${shlibs:Depends},33 ${shlibs:Depends},
34Recommends: libglib2.0-bin,
35 upstart,
34Description: service to allow requesting payment for an item36Description: service to allow requesting payment for an item
35 Allows applications to request an item be paid for by the user.37 Allows applications to request an item be paid for by the user.
36 This requires interaction with the server backend to handle the38 This requires interaction with the server backend to handle the
3739
=== modified file 'tests/setup-staging.sh'
--- tests/setup-staging.sh 2014-06-30 17:32:19 +0000
+++ tests/setup-staging.sh 2014-06-30 17:32:19 +0000
@@ -13,13 +13,13 @@
1313
14echo "Setting up upstart environment variables"14echo "Setting up upstart environment variables"
1515
16initctl set-env --global SSO_AUTH_BASE_URL=$SSO_AUTH_BASE_URL16/sbin/initctl set-env --global SSO_AUTH_BASE_URL=$SSO_AUTH_BASE_URL
17initctl set-env --global SSO_UONE_BASE_URL=$SSO_UONE_BASE_URL17/sbin/initctl set-env --global SSO_UONE_BASE_URL=$SSO_UONE_BASE_URL
18initctl set-env --global PAY_BASE_URL=$PAY_BASE_URL18/sbin/initctl set-env --global PAY_BASE_URL=$PAY_BASE_URL
19initctl set-env --global URL_PACKAGE_INFO=$URL_PACKAGE_INFO19/sbin/initctl set-env --global URL_PACKAGE_INFO=$URL_PACKAGE_INFO
20initctl set-env --global ACCOUNT_CREDS_URL=$ACCOUNT_CREDS_URL20/sbin/initctl set-env --global ACCOUNT_CREDS_URL=$ACCOUNT_CREDS_URL
21initctl set-env --global ADD_PAYMENT_URL=$ADD_PAYMENT_URL21/sbin/initctl set-env --global ADD_PAYMENT_URL=$ADD_PAYMENT_URL
22initctl set-env --global U1_SEARCH_BASE_URL=$U1_SEARCH_BASE_URL22/sbin/initctl set-env --global U1_SEARCH_BASE_URL=$U1_SEARCH_BASE_URL
2323
24echo "Setting up dbus environment variables"24echo "Setting up dbus environment variables"
2525
@@ -30,7 +30,7 @@
30 "[{'SSO_AUTH_BASE_URL', '$SSO_AUTH_BASE_URL'}, {'SSO_UONE_BASE_URL', '$SSO_UONE_BASE_URL'}, {'PAY_BASE_URL', '$PAY_BASE_URL'}, {'URL_PACKAGE_INFO', '$URL_PACKAGE_INFO'}, {'ACCOUNT_CREDS_URL', '$ACCOUNT_CREDS_URL'}, {'ADD_PAYMENT_URL', '$ADD_PAYMENT_URL'}, {'U1_SEARCH_BASE_URL', '$U1_SEARCH_BASE_URL'}]"30 "[{'SSO_AUTH_BASE_URL', '$SSO_AUTH_BASE_URL'}, {'SSO_UONE_BASE_URL', '$SSO_UONE_BASE_URL'}, {'PAY_BASE_URL', '$PAY_BASE_URL'}, {'URL_PACKAGE_INFO', '$URL_PACKAGE_INFO'}, {'ACCOUNT_CREDS_URL', '$ACCOUNT_CREDS_URL'}, {'ADD_PAYMENT_URL', '$ADD_PAYMENT_URL'}, {'U1_SEARCH_BASE_URL', '$U1_SEARCH_BASE_URL'}]"
3131
32echo "Restarting scope registry"32echo "Restarting scope registry"
33restart scope-registry33/sbin/restart scope-registry
3434
35echo "Restarting pay service"35echo "Restarting pay service"
36restart pay-service36/sbin/restart pay-service

Subscribers

People subscribed via source and target branches