Merge lp:~dobey/pay-service/fix-script-path into lp:pay-service/14.10

Proposed by dobey
Status: Merged
Approved by: Alejandro J. Cura
Approved revision: 12
Merged at revision: 13
Proposed branch: lp:~dobey/pay-service/fix-script-path
Merge into: lp:pay-service/14.10
Prerequisite: lp:~ted/pay-service/staging-dbus
Diff against target: 47 lines (+11/-9)
2 files modified
debian/control (+2/-0)
tests/setup-staging.sh (+9/-9)
To merge this branch: bzr merge lp:~dobey/pay-service/fix-script-path
Reviewer Review Type Date Requested Status
Alejandro J. Cura (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+225061@code.launchpad.net

Commit message

Recommend libglib2.0-bin and upstart as setup-staging.sh requires them.
Specify the full path to initctl and restart as /sbin is not in $PATH.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alejandro J. Cura (alecu) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2014-06-13 17:05:49 +0000
3+++ debian/control 2014-06-30 17:32:19 +0000
4@@ -31,6 +31,8 @@
5 Pre-Depends: ${misc:Pre-Depends},
6 Depends: ${misc:Depends},
7 ${shlibs:Depends},
8+Recommends: libglib2.0-bin,
9+ upstart,
10 Description: service to allow requesting payment for an item
11 Allows applications to request an item be paid for by the user.
12 This requires interaction with the server backend to handle the
13
14=== modified file 'tests/setup-staging.sh'
15--- tests/setup-staging.sh 2014-06-30 17:32:19 +0000
16+++ tests/setup-staging.sh 2014-06-30 17:32:19 +0000
17@@ -13,13 +13,13 @@
18
19 echo "Setting up upstart environment variables"
20
21-initctl set-env --global SSO_AUTH_BASE_URL=$SSO_AUTH_BASE_URL
22-initctl set-env --global SSO_UONE_BASE_URL=$SSO_UONE_BASE_URL
23-initctl set-env --global PAY_BASE_URL=$PAY_BASE_URL
24-initctl set-env --global URL_PACKAGE_INFO=$URL_PACKAGE_INFO
25-initctl set-env --global ACCOUNT_CREDS_URL=$ACCOUNT_CREDS_URL
26-initctl set-env --global ADD_PAYMENT_URL=$ADD_PAYMENT_URL
27-initctl set-env --global U1_SEARCH_BASE_URL=$U1_SEARCH_BASE_URL
28+/sbin/initctl set-env --global SSO_AUTH_BASE_URL=$SSO_AUTH_BASE_URL
29+/sbin/initctl set-env --global SSO_UONE_BASE_URL=$SSO_UONE_BASE_URL
30+/sbin/initctl set-env --global PAY_BASE_URL=$PAY_BASE_URL
31+/sbin/initctl set-env --global URL_PACKAGE_INFO=$URL_PACKAGE_INFO
32+/sbin/initctl set-env --global ACCOUNT_CREDS_URL=$ACCOUNT_CREDS_URL
33+/sbin/initctl set-env --global ADD_PAYMENT_URL=$ADD_PAYMENT_URL
34+/sbin/initctl set-env --global U1_SEARCH_BASE_URL=$U1_SEARCH_BASE_URL
35
36 echo "Setting up dbus environment variables"
37
38@@ -30,7 +30,7 @@
39 "[{'SSO_AUTH_BASE_URL', '$SSO_AUTH_BASE_URL'}, {'SSO_UONE_BASE_URL', '$SSO_UONE_BASE_URL'}, {'PAY_BASE_URL', '$PAY_BASE_URL'}, {'URL_PACKAGE_INFO', '$URL_PACKAGE_INFO'}, {'ACCOUNT_CREDS_URL', '$ACCOUNT_CREDS_URL'}, {'ADD_PAYMENT_URL', '$ADD_PAYMENT_URL'}, {'U1_SEARCH_BASE_URL', '$U1_SEARCH_BASE_URL'}]"
40
41 echo "Restarting scope registry"
42-restart scope-registry
43+/sbin/restart scope-registry
44
45 echo "Restarting pay service"
46-restart pay-service
47+/sbin/restart pay-service

Subscribers

People subscribed via source and target branches