Code review comment for lp:~dobey/indicator-display/fix-coverage

Revision history for this message
Ted Gould (ted) wrote :

I think that instead of defining the variable in the parent scope, it should instead be a global property. This way you don't have to track the level of recursion in each file. Also, with set property you can do an append:

set_property(GLOBAL APPEND PROPERTY COVERAGE_TEST_TARGETS ${TEST_NAME})

review: Needs Information

« Back to merge proposal