Code review comment for lp:~dobey/dirspec/python3

Revision history for this message
Diego Sarmentero (diegosarmentero) wrote :

======================================================================
FAIL: test_darwin_pkgd (dirspec.tests.test_utils.DarwinPkgdTestCase)
dirspec.tests.test_utils.DarwinPkgdTestCase.test_darwin_pkgd
----------------------------------------------------------------------
_StringException: Traceback (most recent call last):
  File "x:\dirspec-dobye\dirspec\tests\test_utils.py", line 194, in test_darwin_pkgd
    self.assertEquals(path, expectedpath)
MismatchError: !=:
reference = u'x:\\dirspec-dobye\\dirspec\\utils.py\\Contents\\Resources\\Foo.app\\Contents\\MacOS\\foo'
actual = u'x:\\dirspec-dobye\\dirspec\\utils.py/Contents/Resources/Foo.app/Contents/MacOS/foo'

======================================================================
FAIL: test_linux_src_relative_path_exists (dirspec.tests.test_utils.PosixTestCase)
dirspec.tests.test_utils.PosixTestCase.test_linux_src_relative_path_exists
----------------------------------------------------------------------
_StringException: Traceback (most recent call last):
  File "x:\dirspec-dobye\dirspec\tests\test_utils.py", line 250, in test_linux_src_relative_path_exists
    self.assertEquals(path, expectedpath)
MismatchError: u'/path/to/bin\\foo' != u'/path/to/bin/foo'

======================================================================
FAIL: test_unfrozen_dev_toplevel (dirspec.tests.test_utils.UnfrozenSrcTestCase)
dirspec.tests.test_utils.UnfrozenSrcTestCase.test_unfrozen_dev_toplevel
----------------------------------------------------------------------
_StringException: Traceback (most recent call last):
  File "x:\dirspec-dobye\dirspec\tests\test_utils.py", line 164, in test_unfrozen_dev_toplevel
    self.assertEquals(path, "/path/to/bin/foo")
MismatchError: u'/path/to/bin\\foo' != u'/path/to/bin/foo'

----------------------------------------------------------------------
Ran 32 tests in 0.053s

FAILED (failures=3, skipped=2)

review: Needs Fixing

« Back to merge proposal