Code review comment for lp:~dobey/cupstream2distro/native-versions

That looks good. Thanks a lot for the patch!

Just two small things (which are related):

as you can see in test_create_new_packaging_version_from_native(), we enable transforming a native version in a split mode. This is when upstream are bumping the changelog themselves without really knowing what they do, so we enable that use case.

The test is still passing because you added the "+" check in :
+ elif not "-" in base_package_version and "+" in base_package_version:

However, I think that's a use case to support as well for native packages (and not forcing adding a + for the bootstrapping).

What do you think detecting native reading debian/source/format as well? That way, you can remove the check "+" in base_package_version.

And so adding a test for the additional case:
test_create_new_packaging_version_from_native should still work:
42 to 42+13.10.19830913-0ubuntu1 for split mode

and a new one from:
42 to 42+13.10.19830913 for native mode

What do you think?